Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[balsa] Disallow CR not followed by LF in header values. (#34… #35025

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

alyssawilk
Copy link
Contributor

…829)"

This reverts commit f15ec82.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…oyproxy#34829)"

This reverts commit f15ec82.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #35025 was opened by alyssawilk.

see: more, trace.

@phlax
Copy link
Member

phlax commented Jul 2, 2024

/retest

@alyssawilk alyssawilk marked this pull request as ready for review July 2, 2024 20:37
@alyssawilk alyssawilk enabled auto-merge (squash) July 2, 2024 20:37
@alyssawilk alyssawilk merged commit d687137 into envoyproxy:main Jul 3, 2024
51 of 52 checks passed
cainelli pushed a commit to cainelli/envoy that referenced this pull request Jul 5, 2024
…oyproxy#34… (envoyproxy#35025)

…829)"

This reverts commit f15ec82.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli pushed a commit to cainelli/envoy that referenced this pull request Jul 5, 2024
…oyproxy#34… (envoyproxy#35025)

…829)"

This reverts commit f15ec82.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli pushed a commit to cainelli/envoy that referenced this pull request Jul 5, 2024
…oyproxy#34… (envoyproxy#35025)

…829)"

This reverts commit f15ec82.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli pushed a commit to cainelli/envoy that referenced this pull request Jul 5, 2024
…oyproxy#34… (envoyproxy#35025)

…829)"

This reverts commit f15ec82.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants