Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocketmq: move to contrib #17796

Merged
merged 2 commits into from
Aug 21, 2021
Merged

rocketmq: move to contrib #17796

merged 2 commits into from
Aug 21, 2021

Conversation

mattklein123
Copy link
Member

Part of #14078

Risk Level: Low
Testing: Existing tests
Docs Changes: Automatic
Release Notes: Added
Platform Specific Features: N/A

Part of #14078

Signed-off-by: Matt Klein <mklein@lyft.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #17796 was opened by mattklein123.

see: more, trace.

Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123 mattklein123 merged commit 5b63ef4 into main Aug 21, 2021
@mattklein123 mattklein123 deleted the rocket_contrib branch August 21, 2021 15:01
johanbrandhorst added a commit to johanbrandhorst/envoy that referenced this pull request Aug 23, 2021
envoyproxy#17796 moved rocketmq to `contrib`, but
forgot to update the relative import in v4alpha/rocketmq_proxy.proto as it did
for v3/rocketmq_proxy.proto. Update the import to fix the Protobuf generation.

This was discovered when trying to build latest envoy with `buf`. Would you be interested
in adding some `buf` steps to your CI to avoid this sort of issue in the future?

Signed-off-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
phlax added a commit to phlax/envoy that referenced this pull request Aug 24, 2021
This reverts commit 5b63ef4.

Signed-off-by: Ryan Northey <ryan@synca.io>
mpuncel added a commit to mpuncel/envoy that referenced this pull request Aug 25, 2021
* main: (32 commits)
  Stop processing pending H/2 frames if connection transitioned to the closed state
  http2: limit use of deferred resets in the http2 codec to server-side connections
  Abort filter chain iteration on local reply
  Reject or strip fragment from request URI
  ext-authz: merge duplicate headers from client request in check request
  common: introduce stable logger /w examples in DNS  (envoyproxy#17772)
  route: fast return when route matches failed (envoyproxy#17769)
  owners: add owners for dubbo proxy network filter (envoyproxy#17820)
  config/router/tcp_proxy/options: v2 API, boosting and --bootstrap-version CLI removal. (envoyproxy#17724)
  coverage: revert the limit http/cache to 92.6. (envoyproxy#17817)
  network: rename SocketAddressProvider as ConnectionInfoProvider (envoyproxy#17717)
  test: bumping coverage (envoyproxy#17757)
  conn_pool: Minor cleanups to ConnPoolBaseImpl (envoyproxy#17710)
  Split VaryHeader into VaryAllowList and VaryUtils to organize vary-related logic (envoyproxy#17728)
  ext_proc: Make tests more resilient to IPv6 support (envoyproxy#17784)
  Remove invlaid backquote from doc (envoyproxy#17797)
  rocketmq: move to contrib (envoyproxy#17796)
  kafka: upstream kafka facade in mesh-filter (envoyproxy#17783)
  ecds: create shared base class for DynamicFilterConfigProviderImpl (envoyproxy#17735)
  Change log level from debug to trace (envoyproxy#17774)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants