-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstreams: initial boilerplate/skeleton for metadata upstream #15615
Conversation
Signed-off-by: Taylor Barrella <tabarr@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo build target and comments
|
||
envoy_package() | ||
|
||
envoy_cc_test( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
envoy_extension_cc_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a TODO for this; it requires adding to extensions_build_config.bzl
which requires a config registration class
Also: I am not sure if you should add to https://github.com/envoyproxy/envoy/blob/main/source/extensions/extensions_build_config.bzl at this moment |
Signed-off-by: Taylor Barrella <tabarr@google.com>
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Commit Message:
upstreams: initial boilerplate/skeleton for metadata upstream
Signed-off-by: Taylor Barrella tabarr@google.com
Additional Description:
A small commit so that it's easier to review. This is meant to be the smallest testable unit, establishing the code location and some naming
cc @lambdai
Risk Level: Low
Testing: Unit
Docs Changes: N/A
Release Notes: N/A
#15472