Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstreams: initial boilerplate/skeleton for metadata upstream #15615

Closed
wants to merge 2 commits into from

Conversation

tbarrella
Copy link
Contributor

Commit Message:
upstreams: initial boilerplate/skeleton for metadata upstream

Signed-off-by: Taylor Barrella tabarr@google.com

Additional Description:

A small commit so that it's easier to review. This is meant to be the smallest testable unit, establishing the code location and some naming

cc @lambdai

Risk Level: Low
Testing: Unit
Docs Changes: N/A
Release Notes: N/A
#15472

Signed-off-by: Taylor Barrella <tabarr@google.com>
Copy link
Contributor

@lambdai lambdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo build target and comments


envoy_package()

envoy_cc_test(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

envoy_extension_cc_test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a TODO for this; it requires adding to extensions_build_config.bzl which requires a config registration class

@lambdai
Copy link
Contributor

lambdai commented Mar 22, 2021

Also: I am not sure if you should add to https://github.com/envoyproxy/envoy/blob/main/source/extensions/extensions_build_config.bzl at this moment

Signed-off-by: Taylor Barrella <tabarr@google.com>
@tbarrella tbarrella requested a review from lambdai March 22, 2021 23:51
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 22, 2021
@github-actions
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants