Add variable binding support #15338
Add variable binding support #15338
Conversation
|
Hi @jhance, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
Thanks for this draft pr. Per my reading, the upstream gRPC server takes If so, the code seems pretty simple. It will not add too much complexity to the envoy filter code. I am ok with it. It will be clearer if the issue title or pr title can be something like: "pack unknown parameters into HttpBody extension." |
| message UnknownVariableBindings { | ||
| map<string, string> bindings = 1; | ||
| } |
There was a problem hiding this comment.
add comment for the message and fields.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
… extension (#34999) Commit Message: [grpc-transcoder] Add option to pack unknown parameters into HttpBody extension Additional Description: We've been using this behavior for years, with PR #15338 as a patch. Finally getting around to trying to upstream the behavior to make it available for others, and to make it so I don't have to keep repositioning the patch. Unlike #15338 I'm also adding a configuration option so that no behavior change will occur without a corresponding configuration change. Risk Level: Very low, guarded by a new config field. Testing: Added positive unit tests, added conditions to other tests for the negative case. Docs Changes: Autogen Fixes #14710 --------- Signed-off-by: Raven Black <ravenblack@dropbox.com>
Commit Message: Add unknown variable binding support to grpc transcoder
Additional Description: In some cases the names of the variable bindings may not be known ahead of time and downstream needs to receive an arbitrary mapping. This implements support for such a mapping.
Risk Level: Low
Testing: As this is mostly for demonstration purposes testing deferred until after further discussion.
Docs Changes:
Release Notes:
When allowing missing variable bindings, missing bindings are added to a HttpBody extension as a map of strings.
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #14710
[Optional Deprecated:]
[Optional API Considerations:]