build: Add envoy_extension_py_test for excluding extensions with py_tests #15319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @markguan-stripe, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: Mark Guan <markguan@stripe.com>
Signed-off-by: Mark Guan <markguan@stripe.com>
Signed-off-by: Mark Guan <markguan@stripe.com>
Signed-off-by: Mark Guan <markguan@stripe.com>
lizan
approved these changes
Mar 5, 2021
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Add envoy_extension_py_test too allow for excluding extensions that have py_tests in builds
Additional Description:
Currently, we can't exclude the
envoy.filters.network.kafka_brokerextension from our build because the kafka_broker_integration_test py_test will fail. This prevents us from reducing our build size. Instead, we should add a wrapper around py_tests used in extensions, similar to envoy_extension_cc_test, so that the test won't be included as a target whenextension_nameis not inEXTENSIONS. This will be useful going forward if more extensions end up using py_tests.Risk Level: Low
Testing: Manual testing on all tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]