examples: test/fix websocket ci flake #14941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
Retrying Azure Pipelines: |
phlax
changed the title
ggreenway
approved these changes
Feb 4, 2021
|
/retest |
|
Retrying Azure Pipelines: |
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Feb 5, 2021
switch to 127.0.0.1 from localhost in ws example tests as this seeems to make ci <> websocat flakey Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Shikugawa <rei@tetrate.io>
Shikugawa
added a commit
that referenced
this pull request
Feb 5, 2021
* docs: kickoff 1.17.1 Signed-off-by: Shikugawa <rei@tetrate.io> * add version history Signed-off-by: Shikugawa <rei@tetrate.io> * add versionversion Signed-off-by: Shikugawa <rei@tetrate.io> * master -> main Signed-off-by: Shikugawa <rei@tetrate.io> * fix Signed-off-by: Shikugawa <rei@tetrate.io> * fix Signed-off-by: Shikugawa <rei@tetrate.io> * fix kafka server source Signed-off-by: Shikugawa <rei@tetrate.io> * deps: Add more SHAs to configs and kafka requirements.txt (#14887) Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Shikugawa <rei@tetrate.io> * conflict Signed-off-by: yanavlasov <yavlasov@google.com> * examples: test/fix websocket ci flake (#14941) switch to 127.0.0.1 from localhost in ws example tests as this seeems to make ci <> websocat flakey Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Shikugawa <rei@tetrate.io> Co-authored-by: Dhi Aurrahman <dio@rockybars.com> Co-authored-by: yanavlasov <yavlasov@google.com> Co-authored-by: phlax <phlax@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: examples: Use ip4 address in websocket examples
Additional Description:
switch to
127.0.0.1fromlocalhostin ws example tests as this seeems to make ci <> websocat flakeyRisk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #14939
[Optional Deprecated:]
[Optional API Considerations:]