-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filters: Add dependencies.proto #14750
Changes from 9 commits
b42f1d1
74bd4ea
75167c9
ee97b96
ea91bd2
ad6d7d8
541a5bd
41fe37c
c43f017
dbd82aa
b0784e9
17e320a
daa7da9
04096c4
a6a90e0
72f1c89
9625cc0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# DO NOT EDIT. This file is generated by tools/proto_format/proto_sync.py. | ||
|
||
load("@envoy_api//bazel:api_build_system.bzl", "api_proto_package") | ||
|
||
licenses(["notice"]) # Apache 2 | ||
|
||
api_proto_package( | ||
deps = ["@com_github_cncf_udpa//udpa/annotations:pkg"], | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
syntax = "proto3"; | ||
|
||
package envoy.extensions.filters.common.dependency.v3; | ||
htuch marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
import "udpa/annotations/migrate.proto"; | ||
import "udpa/annotations/status.proto"; | ||
|
||
option java_package = "io.envoyproxy.envoy.extensions.filters.common.dependency.v3"; | ||
option java_outer_classname = "DependencyProto"; | ||
option java_multiple_files = true; | ||
option (udpa.annotations.file_status).package_version_status = ACTIVE; | ||
|
||
// [#protodoc-title: Filter dependency specification] | ||
|
||
// Dependency specification and string identifier. | ||
message Dependency { | ||
enum DependencyType { | ||
HEADER = 0; | ||
FILTER_STATE_KEY = 1; | ||
DYNAMIC_METADATA = 2; | ||
} | ||
|
||
// The kind of dependency. | ||
DependencyType type = 1; | ||
|
||
// String identifier for the dependency. | ||
string name = 2; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please comment all fields. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although this is not exactly an API proto, please consider specifying default values if there are, and use PGV for required fields or other fields constraints. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, I think? Not sure if there are validation rules possible for fields other than the string. |
||
} | ||
|
||
// Dependency specification for a filter. For a filter chain to be valid, any | ||
// dependency that is required must be provided by an earlier filter. | ||
message FilterDependencies { | ||
// A list of dependencies required on the decode path. | ||
repeated Dependency decode_required = 1; | ||
|
||
// A list of dependencies provided on the encode path. | ||
repeated Dependency decode_provided = 2; | ||
|
||
// A list of dependencies required on the decode path. | ||
repeated Dependency encode_required = 3; | ||
|
||
// A list of dependencies provided on the encode path. | ||
repeated Dependency encode_provided = 4; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -449,7 +449,8 @@ message FilterStateRule { | |
|
||
// A map of string keys to requirements. The string key is the string value | ||
// in the FilterState with the name specified in the *name* field above. | ||
map<string, JwtRequirement> requires = 3; | ||
map<string, JwtRequirement> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be reverted There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
requires = 3; | ||
} | ||
|
||
// This is the Envoy HTTP filter config for JWT authentication. | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.