cel: patch thread safety issue #13739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
Signed-off-by: Kuat Yessenov <kuat@google.com>
kyessenov
force-pushed
the
patch_cel_cpp
branch
from
697df2d to
3f4bad0
Compare
|
@moderation yes. Internal fix is not ready. I'll follow up with updates once it's all ready and published. It requires a very recent protobuf that I think hasn't been released. |
|
/retest |
|
Retrying Azure Pipelines. |
|
@kyessenov RBE cache is busted, you need to merge |
|
@moderation or @htuch are you ok with this? |
moderation
suggested changes
Oct 27, 2020
bazel/repositories.bzl
Outdated
Comment on lines
351
to
356
| external_http_archive( | ||
| "com_google_cel_cpp", | ||
| patch_args = ["-p1"], | ||
| # Patches to remove "fast" protobuf-internal access | ||
| patches = ["@envoy//bazel:cel-cpp.patch"], | ||
| ) |
There was a problem hiding this comment.
Can you add a TODO explaining when / how the patch can be removed upon protobuf and cel-cpp update?
There was a problem hiding this comment.
Added an explanation.
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
lizan
approved these changes
Oct 27, 2020
kyessenov
added a commit
to istio/envoy
that referenced
this pull request
Oct 27, 2020
Signed-off-by: Kuat Yessenov <kuat@google.com>
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Oct 28, 2020
Signed-off-by: Kuat Yessenov <kuat@google.com>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 30, 2020
* master: (83 commits) tls: Typesafe tls slots (envoyproxy#13789) docs(example): Correct URL for caching example page (envoyproxy#13810) [fuzz] Made health check fuzz more efficient (envoyproxy#13747) rtds: properly scope rtds stats (envoyproxy#13764) http: fixing a bug with IPv6 hosts (envoyproxy#13798) connection: Remember transport socket read resumption requests and replay them when re-enabling read. (envoyproxy#13772) network: adding some accessors for ALPN work. (envoyproxy#13785) docs: added a step about how to handle platform specific extensions (envoyproxy#13759) Fix identation in ip transparency code snippet (envoyproxy#13743) wasm: enable WAVM's stack unwinding feature (envoyproxy#13792) log: set route name for direct response (envoyproxy#13683) Use nghttp2 as external dependsncy in protocol_constraints_lib (envoyproxy#13763) [Windows] Update windows dev docs (envoyproxy#13741) cel: patch thread safety issue (envoyproxy#13739) Windows: Fix ssl_socket_test (envoyproxy#13264) apple dns: add fake api test suite (envoyproxy#13780) overload: scale selected timers in response to load (envoyproxy#13475) examples: Add dynamic configuration (control plane) sandbox (envoyproxy#13746) Removed exception in getResponseStatus() (envoyproxy#13314) network: add timeout for transport connect (envoyproxy#13610) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
Commit Message: Disable fast-path in CEL protobuf wrapper. The fast path uses internal protobuf methods via a private friend. These methods are not thread-safe, and cause an assertion failure when applied to protobufs shared across workers, such as cluster metadata. The fast path will be enabled again once both protobuf and CEL are updated.
Risk Level: low, switches to a different implementation
Testing: none added
Docs Changes: none
Release Notes: none
Reference: istio/istio#28175