Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump envoy-build-tools #13367

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Bump envoy-build-tools #13367

merged 1 commit into from
Oct 2, 2020

Conversation

sunjayBhatia
Copy link
Member

Commit Message:
Bump envoy-build-tools

Fixes flakiness in tls handshake test on Windows and issues with #13264

Additional Description: N/A
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-watchers: FYI only for changes made to (bazel/repository_locations\.bzl)|(api/bazel/repository_locations\.bzl)|(.*/requirements\.txt).

🐱

Caused by: #13367 was opened by sunjayBhatia.

see: more, trace.

@mattklein123 mattklein123 self-assigned this Oct 1, 2020
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! cc @phlax this should have you shellcheck update also I think.

@sunjayBhatia
Copy link
Member Author

/retest

Curious as to why only a few Linux steps failed, check for flakes

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13367 (comment) was created by @sunjayBhatia.

see: more, trace.

@phlax
Copy link
Member

phlax commented Oct 2, 2020

@mattklein123 @sunjayBhatia envoyproxy/envoy-build-tools#103 didnt land yet - not sure if you want to land that first - i can bump the hashes again if not

@sunjayBhatia
Copy link
Member Author

@mattklein123 @sunjayBhatia envoyproxy/envoy-build-tools#103 didnt land yet - not sure if you want to land that first - i can bump the hashes again if not

I just submitted this PR as a rush job to fix test flakiness, but if we want to wait for the shellcheck update we can bump in one go, I have no preference

@mattklein123 mattklein123 merged commit 6712160 into envoyproxy:master Oct 2, 2020
@sunjayBhatia sunjayBhatia deleted the bump-envoy-build-tools branch October 2, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants