Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: exempting a failing test on windows #11839

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Jul 1, 2020

Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
part of #11841

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Contributor Author

FWIW seems like this test flakes a bit on other builds, and is just particularly likely to fail on windows.

@alyssawilk
Copy link
Contributor Author

cc @wrowe

@alyssawilk alyssawilk merged commit 83841da into envoyproxy:master Jul 1, 2020
@wrowe
Copy link
Contributor

wrowe commented Aug 18, 2020

This appears to be resolved now on Windows with the work on simtime, proposing to reenable the test on windows with #12695

@alyssawilk alyssawilk deleted the windows branch October 26, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants