Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client capability for not supporting overprovisioning. #10136

Merged
merged 6 commits into from
Feb 26, 2020
Merged

Add client capability for not supporting overprovisioning. #10136

merged 6 commits into from
Feb 26, 2020

Conversation

markdroth
Copy link
Contributor

Signed-off-by: Mark D. Roth roth@google.com

Description: Add client capability for not supporting overprovisioning.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A

This should eliminate the need for #8093. And we can remove the disable_overprovisioning flag added in #8080, since it never got used. (I can add that to this PR if you'd like.)

@htuch @alyssawilk @snowp

@markdroth
Add client capability for not supporting overprovisioning.
7694881 
Signed-off-by: Mark D. Roth <roth@google.com>
@srini100
Copy link

/cc

@mattklein123 mattklein123 self-assigned this Feb 21, 2020
@mattklein123
Copy link
Member

Thanks LGTM, though I think needs a format/doc fix. Also, if the field will not be used, can you just go ahead and "deprecate" it from v2 and then it will be removed in v3? I think that's fine to do if it was never implemented. Thank you!

/wait

@markdroth
fix doc formatting
e55e1bf 
Signed-off-by: Mark D. Roth <roth@google.com>
@markdroth
deprecate disable_overprovisioning flag
0b6c0b4 
Signed-off-by: Mark D. Roth <roth@google.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10136 was synchronize by markdroth.

see: more, trace.

@markdroth
Copy link
Contributor Author

I've marked the disable_overprovisioning field as deprecated.

I've attempted to fix the formatting. Let's see if the CI is happy...

@markdroth markdroth mentioned this pull request Feb 24, 2020
Closed
@markdroth
fix formatting
3c2d757 
Signed-off-by: Mark D. Roth <roth@google.com>
@markdroth
Copy link
Contributor Author

@mattklein123 The remaining CI failure seems like a bug in the formatter. It wants me to pull in the end of the table, but doing that would break the RST formatting. I'm not sure how to fix this. Can you (or someone who better understand the CI checks) please take a look? Thanks!

@mattklein123
Copy link
Member

Sadly I don't know what the issue is and I don't have the cycles to debug it right now. @envoyproxy/maintainers is there anyone that can help look at this format check?

@markdroth
convert from table to bullet list
7a82df1 
Signed-off-by: Mark D. Roth <roth@google.com>
@markdroth
Copy link
Contributor Author

I've punted by removing the table and replacing it with a bulleted list.

@markdroth
ran fix_format
28efbf8 
Signed-off-by: Mark D. Roth <roth@google.com>
mattklein123
mattklein123 approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 2fcd75f into envoyproxy:master Feb 26, 2020
@markdroth markdroth deleted the xds_capability_graceful_failover branch February 26, 2020 15:27
This was referenced Feb 26, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@mattklein123 mattklein123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markdroth @srini100 @mattklein123