Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.8.0 (Oct 4, 2018) deprecation] turn down v1 API #4617

Closed
mattklein123 opened this issue Oct 5, 2018 · 1 comment
Closed

[v1.8.0 (Oct 4, 2018) deprecation] turn down v1 API #4617

mattklein123 opened this issue Oct 5, 2018 · 1 comment
Assignees
@alyssawilk
Labels
deprecation Feature deprecation tracking tech debt
Milestone
1.9.0

Comments

@mattklein123
Copy link
Member

#3847 (config: making v2-config-only a boolean flag) introduced a deprecation notice for v1.8.0 (Oct 4, 2018). This issue tracks source code cleanup.
@mattklein123 mattklein123 added this to the 1.9.0 milestone Oct 5, 2018
@mattklein123 mattklein123 added deprecation Feature deprecation tracking tech debt labels Oct 5, 2018
@alyssawilk alyssawilk changed the title [v1.8.0 (Oct 4, 2018) deprecation] Remove features marked deprecated in #3847 [v1.8.0 (Oct 4, 2018) deprecation] turn down v1 API Oct 10, 2018
@alyssawilk alyssawilk mentioned this issue Oct 10, 2018
Merged
alyssawilk added a commit that referenced this issue Oct 11, 2018
@alyssawilk
config: turning down v1 config (#4678)
e3a88b4 
Removing the v1 enabling flag, and see if it sticks.

Risk Level: High
Testing: removed the v1 compat test
Docs Changes: not with this PR
Release Notes: Inline.
Part of #4617
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This was referenced Oct 15, 2018
Merged
Merged
htuch pushed a commit that referenced this issue Oct 16, 2018
@alyssawilk @htuch
docs: updating docs with explicit v1 callouts (#4728)
f1b4847 
Part of removing v1 docs.

Risk Level: low (risk of bad docs)
Testing: n/a
Docs Changes: yep
Release Notes: nope
Part of #4617

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk added a commit that referenced this issue Oct 16, 2018
@alyssawilk
docs: removing links to v1 docs (#4743)
91a5ad9 
Risk Level: low (docs only)
Testing: n/a
Docs Changes: yep
Release Notes: nope
Part of #4617

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Contributor

Ok, command line config is gone, and docs links are pruned.
I started in on removing all the v1 API docs, but unfortunately if we're going to keep the REST APIs around for one more version that gets fairly hairy given some things like v1SDS don't have docs outside of the v2 tree. I think this is done enough for this release, and we should do some more clean up after we cut 1.9.

soya3129 pushed a commit to soya3129/envoy that referenced this issue Oct 19, 2018
@alyssawilk
docs: updating docs with explicit v1 callouts (envoyproxy#4728)
61c9e9f 
Part of removing v1 docs.

Risk Level: low (risk of bad docs)
Testing: n/a
Docs Changes: yep
Release Notes: nope
Part of envoyproxy#4617

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Signed-off-by: Yang Song <yasong@yasong00.cam.corp.google.com>
soya3129 pushed a commit to soya3129/envoy that referenced this issue Oct 19, 2018
@alyssawilk
docs: removing links to v1 docs (envoyproxy#4743)
5c6e0e8 
Risk Level: low (docs only)
Testing: n/a
Docs Changes: yep
Release Notes: nope
Part of envoyproxy#4617

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Yang Song <yasong@yasong00.cam.corp.google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
deprecation Feature deprecation tracking tech debt
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
2 participants
@mattklein123 @alyssawilk