-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lld as linker #4170
Labels
Milestone
Comments
@lizan +1 I think we should switch to lld everywhere, especially if we switch the release build over to clang. |
This was referenced Sep 19, 2018
htuch
pushed a commit
that referenced
this issue
Sep 20, 2018
Use lld in clang builds (ASAN/TSAN) #4170 Risk Level: Low (not in release) Testing: ci Docs Changes: N/A Release Notes: N/A Signed-off-by: Lizan Zhou <zlizan@google.com>
This is done. |
@mattklein123 This is done for 2., I would like to still keep this open for 1.? |
Ah ok. SGTM. |
@lizan what if we do this; we point |
lizan
added a commit
that referenced
this issue
Feb 12, 2019
*Description*: Fixes #4170 *Risk Level*: Low *Testing*: CI *Docs Changes*: *Release Notes*: Added Signed-off-by: Lizan Zhou <lizan@tetrate.io>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this issue
Mar 5, 2019
*Description*: Fixes envoyproxy#4170 *Risk Level*: Low *Testing*: CI *Docs Changes*: *Release Notes*: Added Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a part of tool chain revisit (#4159, #4158) and also as a part of (#3741). We should consider use LLD as default linker. LLD is at least twice faster than gold linker, we have more than 300 test target to link so this will improve CI performance.
Options:
A sample benchmark of linking
envoy-static
is here:gold w/o threads (current):
12.01s user 1.32s system 99% cpu 13.358 total
gold w/ threads:
14.24s user 6.97s system 180% cpu 11.762 total
lld w/o threads:
3.63s user 1.15s system 99% cpu 4.805 total
lld w/ threads:
8.64s user 11.24s system 709% cpu 2.802 total
The text was updated successfully, but these errors were encountered: