Skip to content

Commit

Permalink
filter manager: drop assert (#14633)
Browse files Browse the repository at this point in the history
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
  • Loading branch information
Raúl Gutiérrez Segalés authored Jan 11, 2021
1 parent 748a900 commit 74327f2
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion source/common/http/filter_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,10 @@ class OverridableRemoteSocketAddressSetterStreamInfo : public StreamInfo::Stream

void setDownstreamRemoteAddress(
const Network::Address::InstanceConstSharedPtr& downstream_remote_address) {
ASSERT(overridden_downstream_remote_address_ == nullptr);
// TODO(rgs1): we should assert overridden_downstream_remote_address_ is nullptr,
// but we are currently relaxing this as a workaround to:
//
// https://github.com/envoyproxy/envoy/pull/14432#issuecomment-758167614
overridden_downstream_remote_address_ = downstream_remote_address;
}

Expand Down

0 comments on commit 74327f2

Please sign in to comment.