Skip to content

Commit

Permalink
Fix runtime feature variable name (#13533)
Browse files Browse the repository at this point in the history
- change the runtime feature var name from
`envoy.reloadable_features.header_match_on_all_headers` to
`envoy.reloadable_features.http_match_on_all_headers` as this is the
actual variable name defined in
https://github.com/envoyproxy/envoy/blob/master/source/common/runtime/runtime_features.cc

Signed-off-by: Denis Zaitcev <denis@tetrate.io>
  • Loading branch information
Denis Zaitcev authored Oct 13, 2020
1 parent 9181790 commit 55fb16d
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions docs/root/version_history/v1.12.7.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Changes
changes the default behavior to always logically match on all headers. Multiple individual
headers will be logically concatenated with ',' similar to what is done with inline headers. This
makes the behavior effectively consistent. This behavior can be temporary reverted by setting
the runtime value "envoy.reloadable_features.header_match_on_all_headers" to "false".
the runtime value "envoy.reloadable_features.http_match_on_all_headers" to "false".

Targeted fixes have been additionally performed on the following extensions which make them
consider all duplicate headers by default as a comma concatenated list:
Expand All @@ -17,4 +17,4 @@ Changes
4. The Lua filter.

Like primary header matching used in routing, RBAC, etc. this behavior can be disabled by setting
the runtime value "envoy.reloadable_features.header_match_on_all_headers" to false.
the runtime value "envoy.reloadable_features.http_match_on_all_headers" to false.
4 changes: 2 additions & 2 deletions docs/root/version_history/v1.13.5.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Changes
changes the default behavior to always logically match on all headers. Multiple individual
headers will be logically concatenated with ',' similar to what is done with inline headers. This
makes the behavior effectively consistent. This behavior can be temporary reverted by setting
the runtime value "envoy.reloadable_features.header_match_on_all_headers" to "false".
the runtime value "envoy.reloadable_features.http_match_on_all_headers" to "false".

Targeted fixes have been additionally performed on the following extensions which make them
consider all duplicate headers by default as a comma concatenated list:
Expand All @@ -17,7 +17,7 @@ Changes
4. The Lua filter.

Like primary header matching used in routing, RBAC, etc. this behavior can be disabled by setting
the runtime value "envoy.reloadable_features.header_match_on_all_headers" to false.
the runtime value "envoy.reloadable_features.http_match_on_all_headers" to false.
* http: fixed CVE-2020-25017. The setCopy() header map API previously only set the first header in the case of duplicate
non-inline headers. setCopy() now behaves similarly to the other set*() APIs and replaces all found
headers with a single value. This may have had security implications in the extauth filter which
Expand Down
4 changes: 2 additions & 2 deletions docs/root/version_history/v1.14.5.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Changes
This patch changes the default behavior to always logically match on all headers. Multiple individual
headers will be logically concatenated with ',' similar to what is done with inline headers. This
makes the behavior effectively consistent. This behavior can be temporary reverted by setting
the runtime value "envoy.reloadable_features.header_match_on_all_headers" to "false".
the runtime value "envoy.reloadable_features.http_match_on_all_headers" to "false".

Targeted fixes have been additionally performed on the following extensions which make them
consider all duplicate headers by default as a comma concatenated list:
Expand All @@ -17,7 +17,7 @@ Changes
4. The Lua filter.

Like primary header matching used in routing, RBAC, etc. this behavior can be disabled by setting
the runtime value "envoy.reloadable_features.header_match_on_all_headers" to false.
the runtime value "envoy.reloadable_features.http_match_on_all_headers" to false.
* http: fixed CVE-2020-25017. The setCopy() header map API previously only set the first header in the case of duplicate
non-inline headers. setCopy() now behaves similarly to the other set*() APIs and replaces all found
headers with a single value. This may have had security implications in the extauth filter which
Expand Down
4 changes: 2 additions & 2 deletions docs/root/version_history/v1.15.1.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Changes
headers. This patch changes the default behavior to always logically match on all headers.
Multiple individual headers will be logically concatenated with ',' similar to what is done with
inline headers. This makes the behavior effectively consistent. This behavior can be temporary
reverted by setting the runtime value "envoy.reloadable_features.header_match_on_all_headers" to
reverted by setting the runtime value "envoy.reloadable_features.http_match_on_all_headers" to
"false".

Targeted fixes have been additionally performed on the following extensions which make them
Expand All @@ -19,7 +19,7 @@ Changes
4. The Lua filter.

Like primary header matching used in routing, RBAC, etc. this behavior can be disabled by setting
the runtime value "envoy.reloadable_features.header_match_on_all_headers" to false.
the runtime value "envoy.reloadable_features.http_match_on_all_headers" to false.
* http: The setCopy() header map API previously only set the first header in the case of duplicate
non-inline headers. setCopy() now behaves similarly to the other set*() APIs and replaces all found
headers with a single value. This may have had security implications in the extauth filter which
Expand Down

0 comments on commit 55fb16d

Please sign in to comment.