Skip to content

Commit

Permalink
Add platform logic to a few more BUILD targets
Browse files Browse the repository at this point in the history
This avoids more gcc flags from being passed to MSVC compiler.

Signed-off-by: Yechiel Kalmenson <ykalmenson@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
  • Loading branch information
achasveachas authored and wrowe committed Oct 10, 2019
1 parent 37fd5fc commit 02cc715
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions source/extensions/quic_listeners/quiche/platform/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,10 @@ envoy_cc_library(
name = "quic_platform_mem_slice_span_impl_lib",
srcs = ["quic_mem_slice_span_impl.cc"],
hdrs = ["quic_mem_slice_span_impl.h"],
copts = ["-Wno-unused-parameter"],
copts = select({
"//bazel:windows_x86_64": [],
"//conditions:default": ["-Wno-unused-parameter"],
}),
tags = ["nofips"],
visibility = ["//visibility:public"],
deps = [
Expand All @@ -223,10 +226,13 @@ envoy_cc_library(
name = "quic_platform_mem_slice_storage_impl_lib",
srcs = ["quic_mem_slice_storage_impl.cc"],
hdrs = ["quic_mem_slice_storage_impl.h"],
copts = [
"-Wno-error=invalid-offsetof",
"-Wno-unused-parameter",
],
copts = select({
"//bazel:windows_x86_64": [],
"//conditions:default": [
"-Wno-error=invalid-offsetof",
"-Wno-unused-parameter",
],
}),
tags = ["nofips"],
visibility = ["//visibility:public"],
deps = [
Expand Down

0 comments on commit 02cc715

Please sign in to comment.