-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authz_filter: configuration to support Ambassador authorization flow #563
Changes from all commits
61e546f
2c8f23c
9810412
e6c5342
fdd6594
49dedbd
3128f16
339db0e
f663e11
0f55cb6
b0c3389
79d770a
f024a1b
a8db286
e16fcdb
5eceb00
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
syntax = "proto3"; | ||
|
||
package envoy.config.filter.http.ext_authz.v2alpha; | ||
option go_package = "v2alpha"; | ||
|
||
import "envoy/api/v2/core/grpc_service.proto"; | ||
import "envoy/api/v2/core/http_uri.proto"; | ||
|
||
// The external authorization HTTP service configuration. | ||
message HttpService { | ||
// Sets the HTTP server URI which the authorization requests must be sent to. | ||
envoy.api.v2.core.HttpUri server_uri = 1; | ||
|
||
// Sets an optional prefix to the value of authorization request header `path`. | ||
string path_prefix = 2; | ||
} | ||
|
||
message ExtAuthz { | ||
|
||
oneof services { | ||
// The external authorization gRPC service configuration. | ||
envoy.api.v2.core.GrpcService grpc_service = 1; | ||
|
||
// The external authorization HTTP service configuration. | ||
HttpService http_service = 3; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: should it be 2. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it ok to re-index them? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you are right |
||
} | ||
|
||
// The filter's behaviour in case the external authorization service does | ||
// not respond back. If set to true then in case of failure to get a | ||
// response back from the authorization service or getting a response that | ||
// is NOT denied then traffic will be permitted. | ||
// Defaults to false. | ||
bool failure_mode_allow = 2; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the default if not specified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to make this required and >= 0? It's not clear to me when/how to enforce the default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍