-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token id validation #39
Comments
Alphanumeric-only?
Feels like we should basically allow the regex That would allow:
|
@danwlsn any thoughts on this? |
Happy with the keeping it simple; alphanumerical, hyphens and underscores. A couple of notes I would add though. You have I'm in favour of only allowing single hyphen and underscore. Double underscore is too similar. |
Yes, very good point, I think at the moment we don't even auto-downcase before save. Eek.
Yep, also agreed, in some fonts it's definitely confusing enough to be a pathway to impersonating others, especially if a browser font supports ligatures. Thanks for the sense-check. |
* Validate username based on a set of constraints in #39 * Break out some more helpers
We probably need some basic rules in place in terms of what is acceptable to avoid borkage.
The text was updated successfully, but these errors were encountered: