Mixmix/core release tweaks #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Oct 10, 2024
| @@ -68,23 +69,26 @@ async function isWebSocketReady (endpoint) { | |||
| }) | |||
| } | |||
|
|
|||
| export async function jumpStartNetwork (entropy) { | |||
| await entropy.substrate.tx.registry.jumpStartNetwork().signAndSend(entropy.keyring.accounts.registration.pair) | |||
There was a problem hiding this comment.
signAndSend is/was untrustworthy for awaiting on ... so I dropped the await
Figure if it can't complete all the things in 2 mins it's probably junk anyway.
mixmix
commented
Oct 10, 2024
patches/@polkadot+util+13.1.1.patch
Outdated
There was a problem hiding this comment.
This fixes a yarn install problem... some dep bumped the @polkadot/util version a major version .. which is a little disturbing and we should probably .... worry about since polkadot is a monorepo that I imagine bumps in lockstep??? squints 👀
mixmix
commented
Oct 10, 2024
package.json
Outdated
| @@ -64,7 +64,7 @@ | |||
| "postinstall": "patch-package", | |||
| "prepack": "pinst --disable", | |||
| "postpack": "pinst --enable", | |||
| "removedb": "rm -rf .entropy && docker compose --file dev/docker-scripts/two-nodes.yaml down 2> /dev/null" | |||
There was a problem hiding this comment.
🔥 LOL this was a bad time for a minute
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.