Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigRequestHash not a descriptive param #442

Closed
frankiebee opened this issue Dec 16, 2024 · 0 comments · Fixed by #445
Closed

sigRequestHash not a descriptive param #442

frankiebee opened this issue Dec 16, 2024 · 0 comments · Fixed by #445
Assignees

Comments

@frankiebee
Copy link
Contributor

When reviewing the signing message with @mix in reference to the validation milestone we found this param name to be confusing an non descriptive.
This is suposed to be a hex encoded string of the data to be signed

sigRequestHash,

the proposal is to have:

a) better docs around this
b) rename sigRequestHash -> hexMessage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant