Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-5491: fix user preferences when editing a content #266

Open
wants to merge 76 commits into
base: release/7.3
Choose a base branch
from

Conversation

MEM2677
Copy link
Member

@MEM2677 MEM2677 commented Mar 12, 2024

Fixed owner and join groups on content editing

mirkoPan and others added 30 commits November 2, 2023 10:59
ENG-5199 Italian language label in content creation changes when removing and re-adding Italian language
ENG-5253: POST on /api/plugins/cms/contents with unexisting typeCode, resulting in 500 error
ENG-5270: create new API endpoint to save a profile avatar
ENG-5318: In MT env, ActivityStreamInterceptor ERROR after install showcase bundle
ENG-5068: Fix NotFound Page status code
ENG-5368: Fix bug in delete root page request
@MEM2677 MEM2677 requested a review from eugeniosant March 12, 2024 15:55
@MEM2677 MEM2677 self-assigned this Mar 12, 2024
Copy link

Requested publication of version 7.3.1-ENG-5491-PR-266

Copy link
Contributor

@eugeniosant eugeniosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage must not be less than 80%.
The function that must associate the groups (owner and enabled groups) should be done when creating new content, and not at every intermediate operation returning to the editing UI (as would happen in the proposed implementation)

@eugeniosant eugeniosant force-pushed the ENG-5491_Fix-user-preferences-when-editing-a-content branch from 3f466d9 to 2561344 Compare March 26, 2024 10:01
@eugeniosant eugeniosant force-pushed the ENG-5491_Fix-user-preferences-when-editing-a-content branch from 2561344 to 98e5cb0 Compare March 26, 2024 10:12
@eugeniosant eugeniosant marked this pull request as draft March 26, 2024 10:17
Copy link

Requested publication of version 7.3.1-ENG-5491-PR-266

1 similar comment
Copy link

Requested publication of version 7.3.1-ENG-5491-PR-266

@eugeniosant eugeniosant force-pushed the ENG-5491_Fix-user-preferences-when-editing-a-content branch from ce3182d to 97bf28e Compare March 28, 2024 14:33
Copy link

Requested publication of version 7.3.1-ENG-5491-PR-266

@eugeniosant eugeniosant self-requested a review March 28, 2024 15:12
@eugeniosant eugeniosant marked this pull request as ready for review March 28, 2024 15:12
@eugeniosant eugeniosant force-pushed the ENG-5491_Fix-user-preferences-when-editing-a-content branch from 97bf28e to 7a53392 Compare March 28, 2024 15:19
Copy link

Requested publication of version 7.3.1-ENG-5491-PR-266

Copy link

@eugeniosant eugeniosant requested a review from firegloves April 23, 2024 08:11
Copy link
Contributor

@firegloves firegloves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants