Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wix Installer: Incorrect shortcuts in Start Menu #75

Closed
end2endzone opened this issue Nov 12, 2020 · 3 comments
Closed

Wix Installer: Incorrect shortcuts in Start Menu #75

end2endzone opened this issue Nov 12, 2020 · 3 comments
Labels
bug Something isn't working
Milestone
0.5.1

Comments

@end2endzone
Copy link
Owner

end2endzone commented Nov 12, 2020 •
edited
Loading

Describe the bug

  1. README and UserManual shortcuts do not open in browser. In chrome, the path to the file is splitted into 3 different urls:

  1. The shortcut Run Unit Tests points to C:\Program Files\ShellAnything 0.5.0\bin\shellext.dll instead of shellanything_unittest.exe.

  2. The Wix installer (.msi) installs in directory C:\Program Files\ShellAnything while the NSIS installer (.exe) installs in C:\Program Files\ShellAnything 0.5.0.

To Reproduce
Steps to reproduce the behavior:

  1. Install application using the *.msi installer.
  2. Search the new "ShellAnything" menu in Start Menu.
  3. Launch README or UserManual shortcuts.
  4. Launch Run Unit Tests.

Expected behavior
Obvious

Screenshots
N/A

Environment

  • ShellAnything 0.5.0, Windows, 64 bit,
@end2endzone end2endzone added the bug Something isn't working label Nov 12, 2020
@end2endzone
Copy link
Owner Author

@GasDauMin Hi. Could you validate the installers (both) on your side. Both seems to be acting weird with Chrome as my default browser. For example, the README.html shortcut from the .exe installer have the target set to "C:\Program Files\ShellAnything 0.5.0\README.html" (including the double quotes) but chrome always open the file as 3 different urls.

@end2endzone
Copy link
Owner Author

I should be able to open the file in the default browser using one of the following commands:

  1. Open an HTML file with default browser: start "" "C:\Program Files\ShellAnything 0.5.0\README.html"
  2. Open the default URL handler: start "" "file://C:\Program Files\ShellAnything 0.5.0\README.html"

@end2endzone end2endzone modified the milestones: 0.6.0, 0.5.1 Nov 13, 2020
end2endzone added a commit that referenced this issue Nov 14, 2020
@end2endzone
Added AUTHORS, CHANGES, LICENSE and CONTRIBUTING.md files to installe…
8185779 
…r package. Text files without extensions are packaged with 'txt' file extension.

For issue #75
end2endzone added a commit that referenced this issue Nov 14, 2020
@end2endzone
Modified Wix installer:
2e83c44 
- Application how installs in directory `C:\Program Files\ShellAnything 0.5.1`.
- Start menu entry is now named `ShellAnything 0.5.1` instead of `ShellAnything`.

For issue #75
@end2endzone
Copy link
Owner Author

I updated Chrome and now the problem 1 is resolved.
Problem 2 and 3 are resolved in 2e83c44.

end2endzone added a commit that referenced this issue Nov 14, 2020
@end2endzone
Merged 'master' into 'feature-issue23' branch.
249dc78 
Squashed commit of the following:

commit b0ebc99
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 11:40:54 2020 -0500

    Increased product version to 0.6.0.

commit 0aa7e75
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 10:10:06 2020 -0500

    Updated CHANGES for v0.5.1.

commit 7bbc45d
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 09:27:16 2020 -0500

    Moved the generated html files (from markdown) to the build directory.

commit 2e83c44
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 08:44:03 2020 -0500

    Modified Wix installer:
    - Application how installs in directory `C:\Program Files\ShellAnything 0.5.1`.
    - Start menu entry is now named `ShellAnything 0.5.1` instead of `ShellAnything`.

    For issue #75

commit 8185779
Author: Antoine <end2endzone@gmail.com>
Date:   Fri Nov 13 20:16:51 2020 -0500

    Added AUTHORS, CHANGES, LICENSE and CONTRIBUTING.md files to installer package. Text files without extensions are packaged with 'txt' file extension.
    For issue #75

commit 270c48e
Author: Antoine <end2endzone@gmail.com>
Date:   Fri Nov 13 20:16:12 2020 -0500

    Increased product to 0.5.1.

commit 1af4c0c
Merge: c2e7699 2a14529
Author: Mindaugas <GasDauMin@gmail.com>
Date:   Sun Nov 8 09:40:29 2020 +0200

    Merge pull request #74 from end2endzone/feature-issue56

    Reintegrating issue #56 into master branch.

commit 2a14529
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 7 10:58:28 2020 -0500

    Modified TestActionExecute.testVerb() to use shellanything_unittest.exe for debugging instead of cmd.exe which does not well with 'runas' verb.

commit 740af0f
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 7 10:57:20 2020 -0500

    Modified ArgumentsHandler::PrintProcessSettings() to also print command line arguments and also print the settings to an output file.

commit 7412ab8
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 7 09:22:08 2020 -0500

    Implemented custom command line arguments in unit tests.

commit bff3894
Author: Antoine <end2endzone@gmail.com>
Date:   Tue Nov 3 17:35:52 2020 -0500

    Modified ActionExecute::Execute() to delegate to ExecuteVerb() or ExecuteProcess(). Created unit tests.

commit 23e3df9
Author: Antoine <end2endzone@gmail.com>
Date:   Sun Nov 1 07:54:18 2020 -0500

    Updated CHANGES file.
    Moved `ActionExecute::StartProcess()` private.
    Fixed a bad copy paste for `ActionExecute::SetVerb()` and `ActionExecute::GetVerb()`.
    Updated documentation for verb attribute of <exec> element.
    Fixed missing closing quotes in logs of ActionExecute::Execute().
    Created TestObjectFactory.testParseActionExecute() unit tests to validate parsing.
    For issue #56.

commit d0de816
Author: Mindaugas <GasDauMin@gmail.com>
Date:   Wed Oct 7 21:21:16 2020 +0300

    Migrating from CreateProcess to ShellExecuteEx

commit c2e7699
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Oct 3 08:26:27 2020 -0400

    Updated CHANGES for issue #54.

commit 8659617
Author: Mindaugas <GasDauMin@gmail.com>
Date:   Wed Sep 30 21:56:56 2020 +0300

    Bitmap device-independent (DIP) transparency corrections

commit aa627ad
Author: Mindaugas <GasDauMin@gmail.com>
Date:   Sun Sep 27 21:26:45 2020 +0300

    Bitmap device-independent (DIP) transparency
end2endzone added a commit that referenced this issue Nov 21, 2020
@end2endzone
Merge branch 'master' into branch 'feature-issue23' #23
1c2ca19 
Squashed commit of the following:

commit 5969148
Merge: b0ebc99 da19eaf
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 12:29:28 2020 -0500

    Merge branch 'feature-issue23' #23

    * feature-issue23:
      Updated CHANGES for this issue.
      Merged 'master' into 'feature-issue23' branch.
      Added a small contribution.
      Small correction in exprtk attribute documentation.
      Added documentation for exprtk attribute on <property> elements.
      Small corrections.
      Fixed libEval::evaluate() to prevent buffer overflows.
      Implemented exprtk attribute support for ActionProperty. Created unit tests for ActionProperty.
      Implemented exprtk error logging when validating for visibility or validity. Errors are added to the logs.
      Implemented error support in libEval (with unit tests).
      Updated INSTALL.md document for exprtk dependency. Updated UserManual.md for exprtk attribute
      Added exprtk license file: exprtk LICENSE.txt
      Implemented logging for Validator class when an invalid value for class or exprtk attributes. Implemented more testing for exprtk attribute. Added exprtk license file: exprtk LICENSE.txt
      Implemented inversed exprtk support and tests.
      Implemented parsing of attribute `exprtk`. For issue #23.
      Partially reverted code that was commented in error.
      Added a dependency to Exprtk. The library is downloaded and used automatically. The project `libeval` was created to wrap exprtk library for easier usage. Implemented Validator::SetExprtk() and Validator::GetExprtk() with tests. Created the following new properties: `selection.count`, `selection.files.count` and `selection.directories.count`. For issue #23.
      Enabled building of branch `feature-issue23`.

commit da19eaf
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 12:21:04 2020 -0500

    Updated CHANGES for this issue.

commit 249dc78
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 12:07:11 2020 -0500

    Merged 'master' into 'feature-issue23' branch.

    Squashed commit of the following:

    commit b0ebc99
    Author: Antoine <end2endzone@gmail.com>
    Date:   Sat Nov 14 11:40:54 2020 -0500

        Increased product version to 0.6.0.

    commit 0aa7e75
    Author: Antoine <end2endzone@gmail.com>
    Date:   Sat Nov 14 10:10:06 2020 -0500

        Updated CHANGES for v0.5.1.

    commit 7bbc45d
    Author: Antoine <end2endzone@gmail.com>
    Date:   Sat Nov 14 09:27:16 2020 -0500

        Moved the generated html files (from markdown) to the build directory.

    commit 2e83c44
    Author: Antoine <end2endzone@gmail.com>
    Date:   Sat Nov 14 08:44:03 2020 -0500

        Modified Wix installer:
        - Application how installs in directory `C:\Program Files\ShellAnything 0.5.1`.
        - Start menu entry is now named `ShellAnything 0.5.1` instead of `ShellAnything`.

        For issue #75

    commit 8185779
    Author: Antoine <end2endzone@gmail.com>
    Date:   Fri Nov 13 20:16:51 2020 -0500

        Added AUTHORS, CHANGES, LICENSE and CONTRIBUTING.md files to installer package. Text files without extensions are packaged with 'txt' file extension.
        For issue #75

    commit 270c48e
    Author: Antoine <end2endzone@gmail.com>
    Date:   Fri Nov 13 20:16:12 2020 -0500

        Increased product to 0.5.1.

    commit 1af4c0c
    Merge: c2e7699 2a14529
    Author: Mindaugas <GasDauMin@gmail.com>
    Date:   Sun Nov 8 09:40:29 2020 +0200

        Merge pull request #74 from end2endzone/feature-issue56

        Reintegrating issue #56 into master branch.

    commit 2a14529
    Author: Antoine <end2endzone@gmail.com>
    Date:   Sat Nov 7 10:58:28 2020 -0500

        Modified TestActionExecute.testVerb() to use shellanything_unittest.exe for debugging instead of cmd.exe which does not well with 'runas' verb.

    commit 740af0f
    Author: Antoine <end2endzone@gmail.com>
    Date:   Sat Nov 7 10:57:20 2020 -0500

        Modified ArgumentsHandler::PrintProcessSettings() to also print command line arguments and also print the settings to an output file.

    commit 7412ab8
    Author: Antoine <end2endzone@gmail.com>
    Date:   Sat Nov 7 09:22:08 2020 -0500

        Implemented custom command line arguments in unit tests.

    commit bff3894
    Author: Antoine <end2endzone@gmail.com>
    Date:   Tue Nov 3 17:35:52 2020 -0500

        Modified ActionExecute::Execute() to delegate to ExecuteVerb() or ExecuteProcess(). Created unit tests.

    commit 23e3df9
    Author: Antoine <end2endzone@gmail.com>
    Date:   Sun Nov 1 07:54:18 2020 -0500

        Updated CHANGES file.
        Moved `ActionExecute::StartProcess()` private.
        Fixed a bad copy paste for `ActionExecute::SetVerb()` and `ActionExecute::GetVerb()`.
        Updated documentation for verb attribute of <exec> element.
        Fixed missing closing quotes in logs of ActionExecute::Execute().
        Created TestObjectFactory.testParseActionExecute() unit tests to validate parsing.
        For issue #56.

    commit d0de816
    Author: Mindaugas <GasDauMin@gmail.com>
    Date:   Wed Oct 7 21:21:16 2020 +0300

        Migrating from CreateProcess to ShellExecuteEx

    commit c2e7699
    Author: Antoine <end2endzone@gmail.com>
    Date:   Sat Oct 3 08:26:27 2020 -0400

        Updated CHANGES for issue #54.

    commit 8659617
    Author: Mindaugas <GasDauMin@gmail.com>
    Date:   Wed Sep 30 21:56:56 2020 +0300

        Bitmap device-independent (DIP) transparency corrections

    commit aa627ad
    Author: Mindaugas <GasDauMin@gmail.com>
    Date:   Sun Sep 27 21:26:45 2020 +0300

        Bitmap device-independent (DIP) transparency

commit 0be9aac
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 12:05:47 2020 -0500

    Added a small contribution.

commit b0ebc99
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 11:40:54 2020 -0500

    Increased product version to 0.6.0.

commit 0aa7e75
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 10:10:06 2020 -0500

    Updated CHANGES for v0.5.1.

commit 7bbc45d
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 09:27:16 2020 -0500

    Moved the generated html files (from markdown) to the build directory.

commit 2e83c44
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 14 08:44:03 2020 -0500

    Modified Wix installer:
    - Application how installs in directory `C:\Program Files\ShellAnything 0.5.1`.
    - Start menu entry is now named `ShellAnything 0.5.1` instead of `ShellAnything`.

    For issue #75

commit 8185779
Author: Antoine <end2endzone@gmail.com>
Date:   Fri Nov 13 20:16:51 2020 -0500

    Added AUTHORS, CHANGES, LICENSE and CONTRIBUTING.md files to installer package. Text files without extensions are packaged with 'txt' file extension.
    For issue #75

commit 270c48e
Author: Antoine <end2endzone@gmail.com>
Date:   Fri Nov 13 20:16:12 2020 -0500

    Increased product to 0.5.1.

commit 1af4c0c
Merge: c2e7699 2a14529
Author: Mindaugas <GasDauMin@gmail.com>
Date:   Sun Nov 8 09:40:29 2020 +0200

    Merge pull request #74 from end2endzone/feature-issue56

    Reintegrating issue #56 into master branch.

commit 2a14529
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 7 10:58:28 2020 -0500

    Modified TestActionExecute.testVerb() to use shellanything_unittest.exe for debugging instead of cmd.exe which does not well with 'runas' verb.

commit 740af0f
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 7 10:57:20 2020 -0500

    Modified ArgumentsHandler::PrintProcessSettings() to also print command line arguments and also print the settings to an output file.

commit 7412ab8
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Nov 7 09:22:08 2020 -0500

    Implemented custom command line arguments in unit tests.

commit bff3894
Author: Antoine <end2endzone@gmail.com>
Date:   Tue Nov 3 17:35:52 2020 -0500

    Modified ActionExecute::Execute() to delegate to ExecuteVerb() or ExecuteProcess(). Created unit tests.

commit 23e3df9
Author: Antoine <end2endzone@gmail.com>
Date:   Sun Nov 1 07:54:18 2020 -0500

    Updated CHANGES file.
    Moved `ActionExecute::StartProcess()` private.
    Fixed a bad copy paste for `ActionExecute::SetVerb()` and `ActionExecute::GetVerb()`.
    Updated documentation for verb attribute of <exec> element.
    Fixed missing closing quotes in logs of ActionExecute::Execute().
    Created TestObjectFactory.testParseActionExecute() unit tests to validate parsing.
    For issue #56.

commit adc1a2d
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Oct 31 09:41:26 2020 -0400

    Small correction in exprtk attribute documentation.

commit 7bfe79d
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Oct 31 09:33:54 2020 -0400

    Added documentation for exprtk attribute on <property> elements.

commit dc3c459
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Oct 31 09:27:09 2020 -0400

    Small corrections.

commit 22879cb
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Oct 24 12:00:03 2020 -0400

    Fixed libEval::evaluate() to prevent buffer overflows.

commit 98fea11
Author: Antoine <end2endzone@gmail.com>
Date:   Fri Oct 23 19:00:02 2020 -0400

    Implemented exprtk attribute support for ActionProperty.
    Created unit tests for ActionProperty.

commit 74447c0
Author: Antoine <end2endzone@gmail.com>
Date:   Thu Oct 22 18:57:57 2020 -0400

    Implemented exprtk error logging when validating for visibility or validity. Errors are added to the logs.

commit 2990f9d
Author: Antoine <end2endzone@gmail.com>
Date:   Wed Oct 21 18:55:48 2020 -0400

    Implemented error support in libEval (with unit tests).

commit 0aef7da
Author: Antoine <end2endzone@gmail.com>
Date:   Fri Oct 16 20:51:46 2020 -0400

    Updated INSTALL.md document for exprtk dependency.
    Updated UserManual.md for exprtk attribute

commit f70cd8d
Author: Antoine <end2endzone@gmail.com>
Date:   Fri Oct 16 20:48:55 2020 -0400

    Added exprtk license file: exprtk LICENSE.txt

commit c91c033
Author: Antoine <end2endzone@gmail.com>
Date:   Fri Oct 16 20:48:34 2020 -0400

    Implemented logging for Validator class when an invalid value for class or exprtk attributes.
    Implemented more testing for exprtk attribute.
    Added exprtk license file: exprtk LICENSE.txt

commit d0de816
Author: Mindaugas <GasDauMin@gmail.com>
Date:   Wed Oct 7 21:21:16 2020 +0300

    Migrating from CreateProcess to ShellExecuteEx

commit 504f74e
Author: Antoine <end2endzone@gmail.com>
Date:   Sun Oct 4 09:13:01 2020 -0400

    Implemented inversed exprtk support and tests.

commit c2e7699
Author: Antoine <end2endzone@gmail.com>
Date:   Sat Oct 3 08:26:27 2020 -0400

    Updated CHANGES for issue #54.

commit 8659617
Author: Mindaugas <GasDauMin@gmail.com>
Date:   Wed Sep 30 21:56:56 2020 +0300

    Bitmap device-independent (DIP) transparency corrections

commit aa627ad
Author: Mindaugas <GasDauMin@gmail.com>
Date:   Sun Sep 27 21:26:45 2020 +0300

    Bitmap device-independent (DIP) transparency

commit f7ecf2c
Author: Antoine <end2endzone@gmail.com>
Date:   Tue Sep 15 19:12:45 2020 -0400

    Implemented parsing of attribute `exprtk`. For issue #23.

commit cb6b893
Author: Antoine <end2endzone@gmail.com>
Date:   Mon Sep 14 20:21:42 2020 -0400

    Partially reverted code that was commented in error.

commit 08f21fb
Author: Antoine <end2endzone@gmail.com>
Date:   Mon Sep 14 20:20:50 2020 -0400

    Added a dependency to Exprtk. The library is downloaded and used automatically. The project `libeval` was created to wrap exprtk library for easier usage.
    Implemented Validator::SetExprtk() and Validator::GetExprtk() with tests.
    Created the following new properties: `selection.count`, `selection.files.count` and `selection.directories.count`.
    For issue #23.

commit ab055c9
Author: Antoine <end2endzone@gmail.com>
Date:   Sun Sep 13 08:46:48 2020 -0400

    Enabled building of branch `feature-issue23`.

commit 02fcca0
Author: Antoine <end2endzone@gmail.com>
Date:   Mon Sep 7 10:22:05 2020 -0400

    Fixed a small issue with pattern attribute documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.1
Development

No branches or pull requests
1 participant
@end2endzone