The PropertyManager::Expand() method is not optimized #72
Labels
code cleanup
The code needs optimization
enhancement
New feature or request
help wanted
Extra attention is needed
Milestone
Comments
end2endzone
added
enhancement
end2endzone
added a commit
that referenced
this issue
Dec 28, 2020
…e string in-place which is faster. #72
end2endzone
added a commit
that referenced
this issue
Dec 28, 2020
…ntation of PropertyManager::Expand(). Modified PropertyManager::Expand() to expand the given string until all property references are expanded. For issue #72.
end2endzone
added a commit
that referenced
this issue
Dec 29, 2020
…o expands property references that forms a circular reference. For issue #72.
|
The new implementation also have a possible infinite loop issue. The code was also modified to protect the software from infinite loops when trying to expands property references that forms a circular reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The actual implementation is browsing through all known properties and processes a "search and replace" in the given string. This is not optimized. The algorithm is getting slower and slower as we create more properties.
The
PropertyManager::Expand()method should be optimized to search for${...}patterns inside the string and replace the content as required.The text was updated successfully, but these errors were encountered: