Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated NSIS installer references #132

Closed
end2endzone opened this issue Nov 17, 2023 · 0 comments
Closed

Delete deprecated NSIS installer references #132

end2endzone opened this issue Nov 17, 2023 · 0 comments
Labels
code cleanup The code needs optimization
Milestone

Comments

@end2endzone
Copy link
Owner

end2endzone commented Nov 17, 2023

Describe the bug
During configuration time, CMake is trying to detect if NSIS is installed. If NSIS is not installed on the system, the following is output on the console:

-- Could NOT find NSIS (missing: NSIS_MAKE)

This message is confusing to users because is looks like a warnings message when NSIS is never used by ShellAnything.

To Reproduce
Steps to reproduce the behavior:

  1. Configure the project.
  2. CMake will try to detect if NSIS is installed.
  3. The message Could NOT find NSIS (missing: NSIS_MAKE) is displayed on the console.

Expected behavior
NSIS is not required anymore for the project. The custom detection script FindNSIS.cmake is not required anymore. It should have been deleted when #101 was implemented. The find_package(NSIS) from CMakeLists.txt line 8 shall also be removed.

Screenshots
N/A

Environment
N/A

Additional context
N/A

@end2endzone end2endzone added the code cleanup The code needs optimization label Nov 17, 2023
@end2endzone end2endzone added this to the 0.9.0 milestone Nov 29, 2023
@end2endzone end2endzone changed the title Delete deprecated file FindNSIS.cmake. Delete deprecated NSIS installer references Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup The code needs optimization
Projects
None yet
Development

No branches or pull requests

1 participant