-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httpcore 0.14 redesign #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
- I see we added models such as
URL
andOrigin
, which also exist currently in HTTPX. What's the cohabitation strategy? Will these be re-exposed in HTTPX? If they are copies from HTTPX then fine, otherwise are there API changes? - Should we ping some folks of extensions/libraries building upon on
httpcore
? For community purposes and also to assess that the new API still fits the bill for existing use cases? - I'm not sure about
py.typed
-- the diff shows it as deleted? We should make sure to keep it, I believe?
There are (Trying to find a good balance between "low-level API that doesn't deal with any fancy-pants models that just introduce extra surface area to wrangle, and hide from the developer what actual byte representations are like going to go out over the wire" vs. "user friendly API". I've not doc'ed up the models yet, but there's a starter on it, here)
Sure - any suggestions beyond this discussion?
Good catch - sorted! |
Right come on then, best just push on with this, eh? |
See discussion #419
I'm breaking my own rules here with a mega PR that's pulling in all of https://github.com/tomchristie/httpcore-the-directors-cut but there we are. Sometimes these things need doing.