ENYO-5623: Fix ui/Marquee to stop when blurred during restart timer #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2018 09:04
Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>
Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>
webOS101
reviewed
Sep 7, 2018
| @@ -230,7 +230,6 @@ const MarqueeController = hoc(defaultConfig, (config, Wrapped) => { | |||
| handleComplete = (component) => { | |||
| const complete = this.markReady(component); | |||
| if (complete) { | |||
| this.cancelJob.stop(); | |||
There was a problem hiding this comment.
Seems like this is safe enough. I think the thought process was that any time we were going to issue a start, we should prevent cancel from stopping it. But, I think in this instance, it makes sense that if we have a cancel pending, we would want to allow it to prevent the restart. In theory, you could check to see if the cancel was pending and not issue the restart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I have read and understand the contribution guide
A CHANGELOG entry is included
At least one test case is included for this feature or bug fix
Documentation was added or is not needed
This is an API breaking change
Issue Resolved / Feature Added
In #1301, we added a
Jobto manage cancelling marquee instances inMarqueeControllerto allow synchronized marquees to continue when a stop event (e.g. blurring) was immediately followed by a start event (focusing, pointer enter). As a result, it became possible (either through impeccable timing or sluggishness on lower powered hardware) to blur a synchronized marquee during the restart timer causing the job to be scheduled but then reset by the "complete" trigger before it fires.Resolution
Additional Considerations
I couldn't come up with a reason that the "complete" trigger would stop the cancel job. The purpose of the complete trigger is to inform the controller that one instance is done in order to coordinate restarting all instances at the same time. It isn't a trigger to initiate marquee and so shouldn't prevent cancelling (as far as i can tell).