Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move theming into its own file #130

Merged
merged 4 commits into from
Jul 16, 2017
Merged

Move theming into its own file #130

merged 4 commits into from
Jul 16, 2017

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Jul 11, 2017

⚠️ Breaking Change ⚠️

What:

Move ThemeProvider and withTheme exports to emotion/react/theming.

Why:

Because not everyone wants theming and this doesn't force people to include it if they don't want it.

How:

Checklist:

  • Documentation
  • Tests
  • Code complete

@thangngoc89
Copy link
Contributor

Yes. Yes. Yes. I'm upset about the size of emotion after adding theming feature

@codecov-io
Copy link

codecov-io commented Jul 11, 2017

Codecov Report

Merging #130 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   89.06%   89.08%   +0.01%     
==========================================
  Files          16       18       +2     
  Lines         631      632       +1     
  Branches      145      145              
==========================================
+ Hits          562      563       +1     
  Misses         56       56              
  Partials       13       13
Impacted Files Coverage Δ
src/react/index.js 85.71% <ø> (ø)
src/react/theming.js 100% <100%> (ø)
src/react/constants.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e000a...a67aaf7. Read the comment docs.

@emmatown emmatown requested a review from tkh44 July 11, 2017 11:02
@tkh44
Copy link
Member

tkh44 commented Jul 13, 2017

@mitchellhamilton I'm sitting on this until I figure out the glamor and className merging.

@emmatown emmatown mentioned this pull request Jul 13, 2017
14 tasks
@tkh44 tkh44 merged commit a66bb0e into emotion-js:master Jul 16, 2017
@emmatown emmatown deleted the move-theming branch July 30, 2017 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants