Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-5714 - incorrect _cache_key generation fixed #5715

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ it will be removed; but as it won't be user-visible this isn't considered a brea
starting. This will help address some of the intermittent issues seen during install and
upgrades.

- Bugfix: _cache_key is getting generated incorrectly for mappings in ir.json, when using header
with regex in mapping. Always, It should be in the format of {kind}-{version}-{name}-{namespace}.
But header name is getting updated in the place of mapping name, if we created mapping with regex
header.


## [3.8.0] August 29, 2023
[3.8.0]: https://github.com/emissary-ingress/emissary/compare/v3.7.2...v3.8.0

Expand Down
4 changes: 2 additions & 2 deletions python/ambassador/ir/irhttpmapping.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,8 @@ def __init__(
if "regex_headers" in kwargs:
# DON'T do anything special with a regex :authority match: we can't
# do host-based filtering within the IR for it anyway.
for name, value in kwargs.get("regex_headers", {}).items():
hdrs.append(KeyValueDecorator(name, value, regex=True))
for hdr_name, hdr_value in kwargs.get("regex_headers", {}).items():
hdrs.append(KeyValueDecorator(hdr_name, hdr_value, regex=True))

if "host" in kwargs:
# It's deliberate that we'll allow kwargs['host'] to silently override an exact :authority
Expand Down