Correctly handle istio secrets #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppeble
force-pushed
the
issue-1475-istio-mtls
branch
from
d63fdd9 to
a0ddc25
Compare
ppeble
commented
Feb 5, 2020
kflynn
previously approved these changes
Feb 13, 2020
kflynn
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change to correctly consume
istio.io/key-and-certsecret type so that we no longer are required to mount the secret as a volume as specified here.As background, the mounting solution works but we discovered that when
istiosecrets change (say, with an istio upgrade) it seems that Ambassador was not correctly picking up the newkey-and-certsecret. The solution when using the mounted volume method was to reboot Ambassador. With this change Ambassador correctly reads the secret like any other secret and therefore will pick up any changes.Related Issues
Testing
I've performed manual testing of on
istioversions 1.2 and 1.3. I do not have a more recent (1.4) version to test against but nothing in the documentation leads me to believe that there is a change to theistio/key-and-certsecret format.I have added a test to verify that the key is correctly consumed into a
TLSContext. I am open to guidance on how to add additional tests but to be quite honest I am overwhelmed trying to learn howkatworks after a few months away from it. 😬