Make Tests Great Again!

[kflynn]

Well, OK, maybe that's a bit strong. 😉 But:

• Instead of parsing the outer JSON container that comes from watt using the Python YAML parser, use the JSON parser.

  • A YAML parser can always parse JSON, since YAML is a superset, so using the YAML parser made it faster to get things running, but
  • even using the C YAML parser, the YAML parser is on the order of 20x slower than the JSON parser. That is not a typo.
  • I don't know why this is so. I haven't really gotten past boggling at it.

• Make the number of configuration snapshots we keep tunable with the AMBASSADOR_SNAPSHOT_COUNT environment variable, and have the tests cut it to 1 instead of 4.

  • Turns out the Kubernaut cluster is severely disk-constrained, and the accumulation of snapshots was eating all the disk and causing pods to be evicted. Sigh.
  • This doesn't happen if we clamp to one snapshot.

So this brings us back to one test pass that's quick enough to succeed.