Add support for buffers other than a String in TextEdit
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
requested changes
May 18, 2021
| @@ -478,18 +523,24 @@ impl<'t> TextEdit<'t> { | |||
| let did_mutate_text = match event { | |||
| Event::Copy => { | |||
| if cursorp.is_empty() { | |||
| copy_if_not_password(ui, text.clone()); | |||
| copy_if_not_password(ui, text.as_ref().to_owned()); | |||
There was a problem hiding this comment.
Suggested change
| copy_if_not_password(ui, text.as_ref().to_owned()); | |
| copy_if_not_password(ui, text.to_string()); |
is a bit shorter (and iirc it should work since text implements Display)
There was a problem hiding this comment.
Wouldn't calling to_owned on a str bypass the std::fmt formatting, though?
I don't know how it works in general, but there might be a specialization for String and str so it might not matter.
|
The branch conflict seems to be because of the changelog, I added the "Added" heading, should I rebase on master? |
|
yeah, rebase on or merge in master |
…pes other than `String`.
This allows the user to implement text inserting depedent on their type instead of using a `String` and converting back to `S`, which may be a lossless convertion.
…xtBuffer::delete_range`.
…ed into the buffer. This allows implementations to "saturate" the buffer, only allowing for a limited length of characters to be inserted.
Removed `From<String>` bound for `TextBuffer`.
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
|
Should be rebased now? I had to do a |
emilk
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for custom buffers to be used with the
TextEditwidget.I haven't made an issue because this was relatively simple to implement and it's something I need for one of my projects, so I'd likely re-use it even if you'd prefer to not make this change.
The motivation behind this for me is to use an
AsciiStringfrom theasciicrate as the underlying buffer, and also limit it's size to a certain number of max characters.In order to achieve this the
TextBuffertrait hands responsibility of any actual insertions / removals to the type itself, with a default impl forString.Due to the default type of
StringI believe this doesn't break any existing code and a default ofStringis likely the best option either way.This also modifies most operations to be in-place instead of creating a new string and assigning it to it. This should (?) also increase performance slightly, but I doubt it's too noticeable.