Fix plot auto-bounds unset by default #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
approved these changes
Dec 19, 2023
emilk
pushed a commit
that referenced
this pull request
Jan 3, 2024
These PR recently cleaned up the code around auto-bounds, but introduced an involuntary change whereby auto-bounds would not be enabled by default. All plots would default to being not properly centred as a result. - #3587 - #3586 This PR changes the default back to enabled. It also deprecates `auto_bounds_x()` and `auto_bounds_y()`, which could only enable auto-bounds (which is not very useful as auto-bounds were, and now are again, enabled by default). A new `auto_bounds()` API can now be sued to disable auto-bounds if needed. Fixes #3712 Fixes rerun-io/rerun#4503
This was referenced Jan 3, 2024
emilk
added a commit
that referenced
this pull request
Jan 3, 2024
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Jan 3, 2024
### What * Closes #4635 * See also emilk/egui#3763 * Includes this fix: emilk/egui#3722 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4645/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4645/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4645/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4645) - [Docs preview](https://rerun.io/preview/82415b7ed7cb1d02464d80766a7007a9ab8cca08/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/82415b7ed7cb1d02464d80766a7007a9ab8cca08/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
emilk
added a commit
to emilk/egui_plot
that referenced
this pull request
Jul 15, 2024
## Changelog * Fix plot auto-bounds default [#3722](emilk/egui#3722) (thanks [@abey79](https://github.com/abey79)!) --------- Co-authored-by: Antoine Beyeler <49431240+abey79@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR recently cleaned up the code around auto-bounds, but introduced an involuntary change whereby auto-bounds would not be enabled by default. All plots would default to being not properly centred as a result.
auto_bounds/set_auto_boundstoPlotUi#3586This PR changes the default back to enabled. It also deprecates
auto_bounds_x()andauto_bounds_y(), which could only enable auto-bounds (which is not very useful as auto-bounds were, and now are again, enabled by default). A newauto_bounds()API can now be sued to disable auto-bounds if needed.