refactor RunMode: move it from backend to the demo App #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
force-pushed
the
refactor-run_mode
branch
from
e00f94b to
c328121
Compare
parasyte
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
@emilk Thanks for the heads up. I'm happy to report that Continuous RunMode still works correctly on this branch. It also (surprisingly) fixes the animation behavior with Reactive mode on Windows! I believe the changes in backend.rs are responsible for this, since animations should request a repaint, and not just the RunMode.
Input handling is still a bit sketchy with Continuous mode on macOS, but I think honestly this PR fixes enough of the small issues I've had that it obsoletes Continuous mode.
Of course, if the app itself wants to repaint every frame, it can always do that regardless.
This simplifies the egui_glium and egui_web backends substantially, reduces the scope of RunMode to a single file, and removes duplicated code. Basically: this is how I should have written it from the beginning.
emilk
force-pushed
the
refactor-run_mode
branch
from
c328121 to
10bc3cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the
egui_gliumandegui_webbackends substantially, reduces the scope ofRunModeto a single file, and removes duplicated code.Basically: this is how I should have written it from the beginning.
@parasyte You may want to take a look at the the changes to
egui_glium/src/backend.rs. I don't think I could have broken what you fixed, but maybe your fix can be further simplified now that there is less complexity involved w.r.t. #21.