New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kinetic scrolling #20

Merged

emilk merged 3 commits into emilk:master from 1HPorange:kinetic-scrolling

Sep 6, 2020

Contributor

1HPorange commented Sep 4, 2020

I implemented kinetic scrolling to the extent that it makes sense to me right now:

Kinetic scrolling is only active when you drag the background, not when you use the scroll wheel or drag the scroll handle. I feel like people would prefer precise scrolling when using those methods.
Kinetic velocity (like offset) is stored and updated as a Vec2, event though right now we only use the y component
I basically copy-pasted the kinetic part from area.rs; Maybe you would prefer to factor it out, but I'm not sure where to

Markus Webel added 3 commits

September 4, 2020 23:55


          Fixed typo in function description

313bc6e


          Added vertical kinetic scrolling

91e91bc


          Checked off kinetic scrolling from TODO

4548ed4

emilk approved these changes

View reviewed changes

Owner

emilk left a comment

Works nicely; thanks!

emilk merged commit 6b30e21 into emilk:master

ambihelical mentioned this pull request

eframe X11 crash after using thread spawn #1358

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet