Fix blurry rendering on web demo #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t blurry rendering
# Conflicts: # docs/egui_demo_app.js # docs/egui_demo_app_bg.wasm
emilk
reviewed
Feb 1, 2021
There was a problem hiding this comment.
Thank you so much for taking a stab at this!
Unfortunately your rounding only works for integers (many people have non-integral pixels_per_point). Furthermore I only publish a new wasm every other week or so (on a new egui release) so as not to pollute the git history with too many large files. Not easy for you to know!
Anyway, instead of reworking this PR I thought it would be quicker to just create another one, please try it out at #151
|
Closed in favor of #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi emilk ,
This a fix for #103 . As per your suggestion, rounding both values to the nearest even integer did the trick. I don't know if there is a better way to implement this (I don't have much Rust experience). Could add a function to
emath/src/vec2.rsthat works on the struct , but since it would only be used here and this is a hack anyway, I thought that it would be unnecessary. I've compiled the web demo with the latestmasterbranch too.Thanks,
Asparuh