Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add led effect to DCSpy #39

Open
wants to merge 95 commits into
base: master
Choose a base branch
from
Open

Add led effect to DCSpy #39

wants to merge 95 commits into from

Conversation

emcek
Copy link
Owner

@emcek emcek commented Nov 2, 2021 •
edited
Loading

Description

Allow to pulse led when i.e. master caution is set.

what when 2 filed request effect? Flow

  • apply effect_1
  • apply effect_2
    • shutdown
    • save effect_1
    • apply effect_2

optional flow 1

  • deactive effect_1
    • only remove from heap

optional flow 2

  • deactive effect_2
    • remove from heap effect_2
    • shutdown
    • apply effect_1

add callback to exiting BIOS_VALUE

BIOS_VALUE = TypedDict('BIOS_VALUE', {'class': str, 'args': PROTO_ARGS, 'value': Union[int, str], 'max_value': int, 'callback': str}, total=False)

led setting

where (if at all) set options for LED effect

  • config.yaml
  • hardcode
  • BIOS_VALUE (old) as dict

test start_led_pulse vs. start_led_flash

try parametrize setting in config if you end-up with one field

findings

  • No thread, no events, no sleep time needed
  • need keep track of active effects in OrderedDict (due to py3.6 can not be regular dict)
  • when one effect is active others can not be applied

Todo

  • Tests
  • Documentation

@emcek emcek added this to the Release 1.7.0 milestone Nov 2, 2021
@emcek emcek self-assigned this Nov 2, 2021
emcek added 18 commits November 29, 2021 22:23
@emcek
change F-16 bios values agains new BIOS
26a6d70
@emcek
add callback key to BIOS_VALUE dict
056ffb2
@emcek
load callback method when setting callback in BIOS parser buffer
9385119
@emcek
refactor start_led_pulse into more general start_led_effect with DCS-…
18d7a33 
…BIOS field name and wait on event instead of while loop and sleep
@emcek
add general led_handler method
b712fc9
@emcek
Merge branch 'master' into led_support
ff9267c 
# Conflicts:
#	dcspy/aircrafts.py
@emcek
add SC_MASTER_CAUTION_LED for Ka-50
11e6b78
@emcek
update typing
3b670d9
@emcek
ignore type for led_event
1a96d27
@emcek
typo in docstring
fd5b266
@emcek
Merge branch 'master' into led_support
12eb99b
@emcek
use red color
3e89fab
@emcek
try split effect code
2771ed0
@emcek
use NamedTuple ti describe effect info
5659df0
@emcek
rename namedtuple
3e15162
@emcek
rename variable
457878c
@emcek
update type
46fde58
@emcek
longer lines
d07bfdf
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@emcek emcek added the enhancement New feature or request label Dec 30, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@emcek emcek removed this from the Release 1.7.0 milestone Jun 7, 2022
emcek added 8 commits September 1, 2022 19:56
@emcek
Merge branch 'master' into led_support
a8b8ac7 
# Conflicts:
#	CONTRIBUTING.md
#	dcspy/aircraft.py
#	dcspy/utils.py
#	resources/config.yaml
#	tests/test_aircraft.py
#	tests/test_bios.py
#	tests/test_led_sdk.py
#	tests/test_logitech.py
#	tests/test_utils.py
#	uml/classes.puml
@emcek
Merge branch 'master' into led_support
2d1238e 
# Conflicts:
#	CONTRIBUTING.md
#	dcspy/aircraft.py
#	dcspy/utils.py
#	resources/config.yaml
#	tests/test_aircraft.py
#	tests/test_bios.py
#	tests/test_led_sdk.py
#	tests/test_logitech.py
#	tests/test_utils.py
#	uml/classes.puml
@emcek
update BIOS data
bbd611e
@emcek
update BIOS_VALUE type
dfec465
@emcek
change 'max_value' key
bf03498
@emcek
remove key duplication
3be4441
@emcek
Merge branch 'master' into led_support
bf94b9a
@emcek
disable django
e0ae92b
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

emcek and others added 3 commits January 27, 2024 17:04
@emcek
Merge branch 'master' into led_support
0658970 
# Conflicts:
#	.pylintrc
#	CONTRIBUTING.md
#	dcspy/aircraft.py
#	dcspy/config.yaml
#	dcspy/logitech.py
#	dcspy/sdk/led_sdk.py
#	dcspy/utils.py
#	tests/test_aircraft.py
#	tests/test_led_sdk.py
#	tests/test_utils.py
#	uml/classes.puml
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1316e49 
for more information, see https://pre-commit.ci
@emcek
Refactor LED SDK module import statements and constants usage
6835013
@emcek emcek added this to the Release 3.2.0 milestone Jan 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@emcek emcek removed this from the Release 3.2.0 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emcek emcek

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emcek