Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #19649
assign
was re-written to just pass through toObject.assign
. However, the implementation is not ideal - it assigns all the arguments, which includes thetarget
itself. This can lead to problems, e.g. in ember-test-helpers when you have an implementation like this:assign(event, options)
, it will end up asObject.assign(event, event, options)
, and complain that we try to set read-only attributes onevent
.See: emberjs/ember-test-helpers#1077