[BUGFIX release] local variable shadowing assert #17399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wycats
force-pushed
the
fix-assert
branch
3 times, most recently
from
d25463b to
030f373
Compare
Previously we considered the block params to shadow the params, hash,
attributes and named arguments on the same block/element, which was
incorrect.
For example:
```hbs
{{#let (concat "foo" "bar") as |concat|}}
...
{{/let}}
```
In this case the assertion code incorrectly believed the `concat` in
the sub-expression invocation was being shadowed. This is now fixed.
Also fixes a bug where we incorrectly transformed mustaches in attribute
positions:
```hbs
{{#let ... as |foo|}}
<div class={{foo bar}} />
{{/let}}
```
...became...
```hbs
{{#let ... as |foo|}}
<div class={{component foo bar}} />
{{/let}}
```
This is clearly incorrect and has been fixed here as well.
Fixes #17370
rwjblue
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we considered the block params to shadow the params, hash, attributes and named arguments on the same block/element, which was incorrect.
For example:
In this case the assertion code incorrectly believed the
concatin the sub-expression invocation was being shadowed. This is now fixed.Also fixes a bug where we incorrectly transformed mustaches in attribute positions:
...became...
This is clearly incorrect and has been fixed here as well.
Fixes #17370