[DEPRECATION] Remove ember-metal/map #15119
Conversation
There was a problem hiding this comment.
Seems like there is still some usage of this in the wild...
- https://emberobserver.com/code-search?codeQuery=Ember.OrderedSet
- https://emberobserver.com/code-search?codeQuery=Ember.Map
- https://emberobserver.com/code-search?codeQuery=Ember.MapWithDefault
Seems like we should confirm that these usages can be migrated to something else (the ember-data usage seems to be the highest priority), then add a deprecation for using these with an until: 2.16...
|
I'll change this to deprecations this weekend :) |
Add deprecation for ember-metal.map, being deprecated in emberjs/ember.js#15119
Serabe
force-pushed
the
fix/fire-ordered-set
branch
from
193dc92 to
1bb2dea
Compare
|
Updated PR. Not sure I approached the deprecation the best way and I for sure have no idea on which the exact URL would be. Feedback more than welcomed! |
Serabe
changed the title
|
☔ The latest upstream changes (presumably #15134) made this pull request unmergeable. Please resolve the merge conflicts. |
This isn't true, although some scenarios in ED incorrectly used a set, many legitimately require it.
I'm alright with deprecating, but there needs to be a transition plan in place before that. As ember-data does require an efficient OrderedSet. Maybe via add-on, or as part of ember-data itself. |
This PR deprecates three private classes: Map, MapWithDefault and OrderedSet. These classes are private and not being used anyplace in this repo's code. Though they are being used in Ember Data, the team is working on removing their usages.
Serabe
force-pushed
the
fix/fire-ordered-set
branch
from
1bb2dea to
99f0973
Compare
|
Rebased. @stefanpenner we talked about this in #dev-ember and seemed so. In any case, seems more natural to provide an |
Add deprecation for ember-metal.map, being deprecated in emberjs/ember.js#15119
|
I laid out the general path forward in #13815 (comment). Basically, extraction, update ember-data, then land this deprecation. |
|
Closing this. |
ember-metal/mapcontains three private classesOrderedSet,Map,MapWithDefault. They were not used anywhere in the codebase except for testsor reexports, so they are being deprecated.
Ember Data team has been removing their usages.
Added emberjs/website#2884.
Fixes #15041
Fixes #13815