-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
didInitAttrs cannot see bound values unless they are explicitly defined on the component class. #12035
Comments
I can confirm this bug. Immediately after upgrading, I am seeing {{foo-component bar='something'}} init() {
Ember.assert("The {{foo-component}} attribute 'bar' was not configured", this.get('bar'));
}, The following assert throws in 1.13.7 where it would be correctly bound to |
I bumped into this too. This was during Here is a jsbin: http://emberjs.jsbin.com/femezafave/1/edit?html,js,console,output Edit: |
I think I have a fix for this, but I'm writing a test to verify -- unless one of you has a breaking test already? |
I do not. That's great to hear though! |
don't have a breaking test, just a breaking app :-/ |
+1 |
[BUGFIX release] use bracket notation to access unknown attr #12035
Fixed by #12071. |
Will be in a 1.13.8 soonish. |
I just noticed this in 1.13.7. If a property isn't explicitly defined on a component's class then its value is never seen in the didInitAttrs method even though it is bound in the template. Defining the property with a value of null does work but this wasn't required in 1.13.6. I'm not 100% sure if this is a bug or if the previous behavior was incorrect and it's been fixed now.
Ember-twiddle at http://ember-twiddle.com/62d39c8e4f57e0eb1fbb
The text was updated successfully, but these errors were encountered: