-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUGFIX canary] Honor
customEvents
opting out of event listeners.
Setting `customEvents` to a hash in an application is a way to add new listeners that the `EventDispatcher` knows about. Often, users see this and decide that they want to disable a given event (for example `mouseenter` and `mouseleave` events) and think they can do something like: ```javascript var App = Ember.Application.create({ customEvents: { mouseenter: null, mouseleave: null } }); ``` Unfortunately, that just makes the `EventDispatcher` call a method named `null` on the view/component instances (LOL). This fixes that bug by allowing a `null` value to disable the event listener.
- Loading branch information
Showing
3 changed files
with
88 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters