Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve inject deprecation #293

Merged
merged 8 commits into from
Feb 22, 2025
Merged

Resolve inject deprecation #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ff2a407
Update page-title.ts
NullVoxPopuli Feb 9, 2025
7fbde0e
Trick pnpm
NullVoxPopuli Feb 18, 2025
95678e5
ope
NullVoxPopuli Feb 18, 2025
edf0701
min supported is 4.1
NullVoxPopuli Feb 18, 2025
83d551a
Is 'minimum-supported' an ember-try keyword?
NullVoxPopuli Feb 18, 2025
9b3c1a5
I forgot a comma
NullVoxPopuli Feb 18, 2025
431da3e
What about 4.2
NullVoxPopuli Feb 22, 2025
0275f95
Specify 4.2 instead of 4.1
NullVoxPopuli Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
matrix:
ember-try-scenario:
[
minimum-supported
minimum-supported-4-2,
ember-lts-4.4,
ember-lts-4.12,
ember-lts-5.12,
Expand Down
4 changes: 1 addition & 3 deletions addon/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ ember install ember-page-title

### Compatibility

- Ember.js v3.28 or above
- Ember CLI v3.28 or above
- Node.js v14 or above
- `ember-source` v4.2 or above

<details>
<summary>Fastboot vs Non-Fastboot Notes</summary>
Expand Down
2 changes: 1 addition & 1 deletion addon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"@simple-dom/document": "^1.4.0"
},
"peerDependencies": {
"ember-source": ">= 3.28.0"
"ember-source": ">= 4.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli should this have been changed to 4.2 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye!

},
"devDependencies": {
"@babel/core": "^7.23.6",
Expand Down
2 changes: 1 addition & 1 deletion addon/src/helpers/page-title.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { inject as service } from '@ember/service';
import { service } from '@ember/service';
import Helper from '@ember/component/helper';
import { guidFor } from '@ember/object/internals';

Expand Down
2 changes: 1 addition & 1 deletion addon/src/services/page-title.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { scheduleOnce } from '@ember/runloop';
import Service, { inject as service } from '@ember/service';
import Service, { service } from '@ember/service';
import { isEmpty } from '@ember/utils';
import { assert } from '@ember/debug';
import type ApplicationInstance from '@ember/application/instance';
Expand Down
8 changes: 4 additions & 4 deletions test-app/config/ember-try.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ module.exports = async function () {
usePnpm: true,
scenarios: [
{
name: 'minimum-supported',
name: 'minimum-supported-4-2',
npm: {
devDependencies: {
'ember-source': '~3.28.0',
'ember-cli': '~3.28.0',
'ember-source': '~4.2.0',
'ember-cli': '~4.12.0',
},
},
},
Expand All @@ -20,7 +20,7 @@ module.exports = async function () {
npm: {
devDependencies: {
'ember-source': '~4.4.0',
'ember-cli': '~4.4.0',
'ember-cli': '~4.12.0',
},
},
},
Expand Down
Loading