Merge pull request #390 from ember-cli/fix-issue-with-reexports

Ensure reexported components do not throw an error.
ember-cli · Dec 11, 2019 · fe901c8 · fe901c8
2 parents c8c7b2a + a1e3131
commit fe901c8
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 1 deletion.
diff --git a/lib/colocated-broccoli-plugin.js b/lib/colocated-broccoli-plugin.js
@@ -150,7 +150,7 @@ module.exports = class ColocatedTemplateProcessor extends Plugin {
           }
         );
 
-        if (!jsContents.includes('export default')) {
+        if (hasTemplate && !jsContents.includes('export default')) {
           let message = `\`${relativePath}\` does not contain a \`default export\`. Did you forget to export the component class?`;
           jsContents = `${jsContents}\nthrow new Error(${JSON.stringify(message)});`;
           prefix = '';

diff --git a/node-tests/colocated-broccoli-plugin-test.js b/node-tests/colocated-broccoli-plugin-test.js
@@ -137,6 +137,55 @@ describe('ColocatedTemplateCompiler', function() {
     );
   });
 
+  it('works for re-exported component without a template', async function() {
+    input.write({
+      'app-name-here': {
+        'router.js': '// stuff here',
+        components: {
+          'foo.js': `export { default } from 'some-place';`,
+        },
+        templates: {
+          'application.hbs': `{{outlet}}`,
+        },
+      },
+    });
+
+    let tree = new ColocatedTemplateCompiler(input.path());
+
+    output = createBuilder(tree);
+    await output.build();
+
+    assert.deepStrictEqual(output.read(), {
+      'app-name-here': {
+        'router.js': '// stuff here',
+        components: {
+          'foo.js': `export { default } from 'some-place';`,
+        },
+        templates: {
+          'application.hbs': '{{outlet}}',
+        },
+      },
+    });
+
+    await output.build();
+
+    assert.deepStrictEqual(output.changes(), {}, 'NOOP update has no changes');
+
+    input.write({
+      'app-name-here': {
+        'router.js': '// other stuff here',
+      },
+    });
+
+    await output.build();
+
+    assert.deepStrictEqual(
+      output.changes(),
+      { 'app-name-here/router.js': 'change' },
+      'has only related changes'
+    );
+  });
+
   it('works for typescript component class with template', async function() {
     input.write({
       'app-name-here': {