Prevent fatal errors from leaking #214
Conversation
The errors generated during feature detection are sometimes picked up by frameworks or libraries that use `error_get_last()` in a shutdown handler to look for fatal errors. This change forces an `E_NOTICE` error to be triggered when an error may potentially be leaked, preventing false positives in *most* situations. Fixes #209
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
========================================
- Coverage 100% 99.8% -0.2%
========================================
Files 135 137 +2
Lines 7863 7814 -49
========================================
- Hits 7863 7799 -64
- Misses 0 15 +15
Continue to review full report at Codecov.
|
|
@ezzatron this needs some cleanup, and either coverage being ignored or tested (probably the former?) and I don't know why Travis PHP 5.3 is failing. Leaving it here for now as a possible solution. |
|
PR seems like a good idea! Ignore all my CI tools having a meltdown, I'm facing a whole bunch of issues there at the moment because of the large range of PHP versions I'm trying to support. I really need to drop some of the older ones soon to stay sane. |
|
@shadowhand Out of interest, do you use Phony for anything PHP 5.x? I'm trying to decide which versions of PHP to drop in future. At the moment I think I probably need to retain 5.6 support, but older 5.x versions can probably go. |
|
@ezzatron yes we're still stuck on PHP 5.6 until we complete PHP 7 migration. We're about 60% of the way there, will probably be using PHP 5.6 until year end at least. |
The errors generated during feature detection are sometimes picked up by
frameworks or libraries that use
error_get_last()in a shutdownhandler to look for fatal errors.
This change forces an
E_NOTICEerror to be triggered when an error maypotentially be leaked, preventing false positives in most situations.
Fixes #209