Also fulfil some requirements for perlcritic severity level 3

Author: xtaran

debian/changelog

@@ -5,7 +5,8 @@ dh-dist-zilla (1.3.5) UNRELEASED; urgency=medium
   * Declare compliance with Debian Policy 4.1.1.
   * Bump debhelper compatibility level to 10.
     + Update versioned debhelper build-dependency accordingly.
-  * Make package perlcritic-severity-4-clean.
+  * Make package perlcritic-severity-4-clean. Also fulfil some
+    requirements for perlcritic severity level 3.
 
  -- Axel Beckert <abe@debian.org>  Sun, 11 Dec 2016 13:04:53 +0100
 

debian/generate_manpages.pl

@@ -24,10 +24,10 @@ sub parse_line {
     chomp($line);
 
     # Weed out commments and empty lines
-    next if $line =~ /^#|^$/;
+    next if $line =~ / ^\# | ^$ /x;
 
     # Expect man page section as file suffix
-    my ($name, $section) = split(/\./, $line);
+    my ($name, $section) = split(/ \. /x, $line);
 
     # Expand potential wildcards and check for existence
     my @names = get_names($name);
@@ -44,7 +44,7 @@ sub parse_line {
     foreach my $name (@names) {
         # Remove .pod suffix from final name again
         my $man_page_name = $name;
-        $man_page_name =~ s/\.pod$//;
+        $man_page_name =~ s/ \.pod$ //x;
 
         # Finally call pod2man
         system(@pod2man, "--section=$section",

dh_dist_zilla_origtar

@@ -14,7 +14,7 @@ my $pristine_tar = $dh{PRISTINE_TAR};
 my $no_clean   = $dh{NO_CLEAN};
 my $upstream_version = $dh{VERSION};
 # Strip Debian revision
-$upstream_version =~ s/-[^-]+$//;
+$upstream_version =~ s/-[^-]+$//x;
 
 # First clean artifacts from previous, potentially manual builds
 doit(qw(dzil clean)) unless $no_clean;