Make package perlcritic-severity-4-clean

Author: xtaran

debian/changelog

@@ -5,6 +5,7 @@ dh-dist-zilla (1.3.5) UNRELEASED; urgency=medium
   * Declare compliance with Debian Policy 4.1.1.
   * Bump debhelper compatibility level to 10.
     + Update versioned debhelper build-dependency accordingly.
+  * Make package perlcritic-severity-4-clean.
 
  -- Axel Beckert <abe@debian.org>  Sun, 11 Dec 2016 13:04:53 +0100
 

debian/generate_manpages.pl

@@ -15,6 +15,12 @@
 
 open(my $dmp, '<', $list_of_manpages);
 while (my $line = <$dmp>) {
+    parse_line($line);
+}
+close($dmp);
+
+sub parse_line {
+    my $line = shift;
     chomp($line);
 
     # Weed out commments and empty lines
@@ -44,9 +50,11 @@
         system(@pod2man, "--section=$section",
                $name, "$man_page_name.$section");
     }
+
+    return;
 }
-close($dmp);
 
 sub get_names {
-    return grep { -e } map { glob } @_;
+    my @globs = @_;
+    return grep { -e } map { glob } @globs;
 }

dist_zilla.pm

@@ -6,7 +6,7 @@ use Debian::Debhelper::Dh_Lib;
 my $build_root = ".build";
 my $build_dir = "$build_root/debian-build";
 # Override dzil's looking for $HOME
-$ENV{DZIL_GLOBAL_CONFIG_ROOT} = $build_root;
+local $ENV{DZIL_GLOBAL_CONFIG_ROOT} = $build_root;
 
 insert_before("dh_auto_configure", "dh_dzil_build");