Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: minor fix and clarification #65

Merged

Conversation

lbeckman314
Copy link
Contributor

@lbeckman314 lbeckman314 commented Jan 9, 2024

TODO:

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80582f3) 99.73% compared to head (2a77688) 99.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #65   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          12       12           
  Lines         754      754           
=======================================
  Hits          752      752           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uniqueg uniqueg requested a review from LakiG January 11, 2024 14:35
@uniqueg
Copy link
Member

uniqueg commented Jan 11, 2024

Thanks, @lbeckman314 🙏 @LakiG, can you have a look? It looks good to me, but I'm not sure about the inputs vs input. And perhaps you can also comment on the second point in the "TODO" in the PR description.

@lbeckman314 lbeckman314 marked this pull request as ready for review February 20, 2024 20:03
@uniqueg uniqueg changed the title Minor task test file fixes test: minor fix and clarification Mar 5, 2024
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uniqueg uniqueg merged commit 552ff3c into elixir-cloud-aai:dev Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants