Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to edge-to-edge enforcement in Android 15. #176

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

tuancoltech
Copy link
Member

@tuancoltech tuancoltech commented Apr 2, 2025

  • Migrate to edge-to-edge enforcement in Android 15.
  • Update common-utils to 1.0.5
Screenshot 2025-04-02 at 22 28 56

Summary by CodeRabbit

  • New Features

    • Enhanced the visual style of the StoryBooks screen with an updated status bar appearance and a refined background color for a cleaner, more modern look.
  • Chores

    • Upgraded the elimuCommonutils library to version 1.0.5 for improved performance and stability.

@tuancoltech tuancoltech self-assigned this Apr 2, 2025
@tuancoltech tuancoltech requested a review from a team as a code owner April 2, 2025 09:39
@tuancoltech tuancoltech requested a review from jo-elimu April 2, 2025 09:40
Copy link

coderabbitai bot commented Apr 2, 2025

Walkthrough

The changes update the dependency injection setup in the DataModule by having the providesLanguageProvider method return an Optional<LanguageProvider> and adding map-related annotations. The StoryBooksActivity is modified to adjust its status bar appearance by calling methods to set a light theme and a specific status bar color. Additionally, the activity's layout is updated with a white background attribute, and the version of the elimuCommonutils library in the Gradle versions catalog is updated from 1.0.3 to 1.0.5.

Changes

File(s) Change Summary
.../ai/elimu/vitabu/di/DataModule.kt Updated providesLanguageProvider to return an Optional<LanguageProvider> using Optional.of(LanguageProviderImpl()) and added annotations.
.../vitabu/ui/StoryBooksActivity.kt
.../res/layout/activity_storybooks.xml
In StoryBooksActivity: added calls to setLightStatusBar() and setStatusBarColorCompat(R.color.colorPrimaryDark) in onCreate.
In layout: added android:background="@android:color/white" to the ConstraintLayout.
gradle/libs.versions.toml Updated elimuCommonutils version from 1.0.3 to 1.0.5.

Sequence Diagram(s)

sequenceDiagram
  participant DI as Dependency Injector
  participant DM as DataModule
  participant LPI as LanguageProviderImpl

  DI->>DM: Call providesLanguageProvider()
  DM-->>DI: Return Optional.of(LPI)
Loading
sequenceDiagram
  participant A as StoryBooksActivity
  participant W as Window

  A->>W: setLightStatusBar()
  A->>W: setStatusBarColorCompat(R.color.colorPrimaryDark)
Loading

Assessment against linked issues

Objective Addressed Explanation
Migrate edge-to-edge experience (#174)

Suggested labels

enhancement

Suggested reviewers

  • jo-elimu

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a77e816 and 57e2d7d.

📒 Files selected for processing (4)
  • app/src/main/java/ai/elimu/vitabu/di/DataModule.kt (1 hunks)
  • app/src/main/java/ai/elimu/vitabu/ui/StoryBooksActivity.kt (2 hunks)
  • app/src/main/res/layout/activity_storybooks.xml (1 hunks)
  • gradle/libs.versions.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • app/src/main/res/layout/activity_storybooks.xml
  • app/src/main/java/ai/elimu/vitabu/ui/StoryBooksActivity.kt
  • gradle/libs.versions.toml
  • app/src/main/java/ai/elimu/vitabu/di/DataModule.kt
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build (windows-latest, 21)
  • GitHub Check: test

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@jo-elimu jo-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuancoltech There are merge conflicts.

@tuancoltech tuancoltech force-pushed the migrate_edge_to_edge_enforcement branch from a77e816 to 57e2d7d Compare April 2, 2025 15:23
@tuancoltech tuancoltech requested a review from jo-elimu April 2, 2025 15:28
@tuancoltech
Copy link
Member Author

@tuancoltech There are merge conflicts.

@jo-elimu It has been resolved.

Copy link
Member

@jo-elimu jo-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Before

API_35_Screenshot_20250402_191420

API_35_Screenshot_20250402_191358

API_34_Screenshot_20250402_191310

API_32_Screenshot_20250402_191251

API_26_Screenshot_20250402_191219

After

API_35_Screenshot_20250402_192619

API_35_Screenshot_20250402_192559

API_32_Screenshot_20250402_192525

API_26_Screenshot_20250402_192455

API_34_Screenshot_20250402_192541

@tuancoltech tuancoltech merged commit fcb4d36 into main Apr 2, 2025
7 checks passed
@tuancoltech tuancoltech deleted the migrate_edge_to_edge_enforcement branch April 2, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate edge-to-edge experience in Android 15
2 participants