-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to edge-to-edge enforcement in Android 15. #176
Conversation
WalkthroughThe changes update the dependency injection setup in the Changes
Sequence Diagram(s)sequenceDiagram
participant DI as Dependency Injector
participant DM as DataModule
participant LPI as LanguageProviderImpl
DI->>DM: Call providesLanguageProvider()
DM-->>DI: Return Optional.of(LPI)
sequenceDiagram
participant A as StoryBooksActivity
participant W as Window
A->>W: setLightStatusBar()
A->>W: setStatusBarColorCompat(R.color.colorPrimaryDark)
Assessment against linked issues
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tuancoltech There are merge conflicts.
a77e816
to
57e2d7d
Compare
@jo-elimu It has been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
common-utils
to 1.0.5Summary by CodeRabbit
New Features
Chores
elimuCommonutils
library to version 1.0.5 for improved performance and stability.