python2 removal / salt upgrade

[lsh-0]

• global-python-requisites is deprecated and depends on python2
• blocked by this: mysql module, "cannot use a string pattern on a bytes-like object" saltstack/salt#55811 which is only replicated when using 2018.3

[lsh-0]

@giorgiosironi , just like we have alternate builds for 1604 and 1804, how difficult would it be to configure Jenkins to do builds for different Salt versions? The alt-config would be easy enough but I'm not sure how it would get hooked in to the CI.

I'm going to investigate what Salt is doing to mess with the mysql library for the time being

[lsh-0]

I think Salt is doing the right thing, but the package on 16.04 (python3-mysqldb) is old and doesn't have the fix. Bug has been raised with Ubuntu here: https://bugs.launchpad.net/ubuntu/+source/python-mysqldb/+bug/1800881

it also has a patch I might try applying manually

[lsh-0]

no luck, I think it's for a very similar bug. I'll work through the stacktrace tomorrow and figure something out

[giorgiosironi]

A list of alt-config can be passed to eLifeFormula as an argument:
https://github.com/elifesciences/redirects-formula/blob/6d7311a5a08652933c88a8b93e27206a89978a99/Jenkinsfile#L1
So as long as you define the right key in elife.yaml it should be the same to build different OS versions or different Salt versions.

[lsh-0]

that's really good to know. I think if there were a next-salt alt-config and the master server had already been upgraded then individual formulas (like this one) could be tested for failing states.

[giorgiosironi]

Good plan, and it can be a defaults alternate configuration so that it is always available. Let me know if all of this actually works in practice or explodes for some reason.

[lsh-0]

blocked by this: saltstack/salt#55811 which is only replicated when using 2018.3

AND python3. I just built this on Salt 2018.3 but using Python2 without problems.

I'm going to merge this and focus on the next-salt alt-config.