Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multi-file torrents. Fixed issues. #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ydavs
Copy link

@ydavs ydavs commented Aug 25, 2022

Added support for multi-file torrents.

Fixed bugs:

  1. I saw message length is not consumed in the case of keep-alive messages, which leads to an infinite loop when a keep-alive message is received. Fixed that.
  2. Sending out bitfield is not mandatory. Some trackers don't send out bitfields but instead rely on Have messages. Added support for such a tracker.
  3. Storing pending requests is implemented as an immutable object(namedTuple). This raises an error when a re-request is issued. Instead changed it to use a dictionary.

ydavs added 3 commits August 23, 2022 06:29
…s which eventually leads to an infinite loop.
Re-requesting failed because PendingRequest implemented as namedTuple(immutable), changed it to dict.
@eliasson
Copy link
Owner

eliasson commented Sep 2, 2022

Wow, I was not expecting any PR on this old project, thanks @ydavs ! =)

I'm just going to try it out before merging, hopefully in the next few days.

@eliasson eliasson self-requested a review September 2, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants